-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: v2.0 beta #89
Merged
Merged
chore: v2.0 beta #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set error name to SyntaxError * chore: use RangeError * test: use RangeError * chore: var -> const
* skips setting header row unti a specified string is found in the cells * only emit(this._Row, cells) if it's not the first row * update README to show skipUntil option * update README to show skipUntil option * update README.md [remove extra comma] * fix tests * skipUntil skips setting headers until line number is reached * update readme to show that skipUntil takes a line number int * remove extra blank line * change name of skipUntil opt to skipLines * add cli flags for skipLines * remove extra blank line in junk_rows.csv * update README.md with CLI flag for skipLines * chore: alphabetize option in README * chore: alphabetize CLI flag * chore: update flag description in CLI * zero indexed skipLines * update test to ava * fix test errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging this PR will result in the following:
Breaking Changes
Features
Updates
ava
(faster, snapshots)