-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"premature close" error not thrown in node 8.2.0 or newer #14
Comments
The change in node is being reverted (nodejs/node#15404), so this can be closed |
Glad to see it fixed :) |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There has been a subtile change in node 8.2.0 and newer (nodejs/node#14024) which affect this module.
In a situation where a outgoing http stream is terminated prematurly, this module will pass on an error object on close in node versions 8.1.4 and older. In node version 8.2.0 this module will not pass on an error object.
Here is an example:
In node version 8.1.4 or older this will output:
In node version 8.2.0 or newer the output will just be
undefined
.This is due to a corrected error in node so I am not sure if this is expected behaviour. The stream are still terminated prematurely so I do kinda expect the same Error from this module in node version 8.2.0 and newer.
See also: nodejs/node#15029
The text was updated successfully, but these errors were encountered: