"premature close" error when calling destroy on source stream

[harishvadali]

I am using node js 8.* and it has new method destroy for Readable streams.

https://nodejs.org/docs/latest-v8.x/api/stream.html#stream_readable_destroy_error

The following is generating premature close error coming from end-of-stream module.

var pump = require('pump')
var fs = require('fs')

var source = fs.createReadStream('/dev/random')
var dest = fs.createWriteStream('/dev/null')

pump(source, dest, function(err) {
  console.log('pipe finished', err)
})

setTimeout(function() {
  source.destroy();
}, 1000)

Any ideas?

[qfox]

see also: mafintosh/end-of-stream#14

[harishvadali]

@zxqfox Looked into the issue you referenced above. Noticed that it was for Writable Stream.

What I am noticing is that when calling destroy() on a Readable Stream, the _readableState.ended field is never set and this is causing end-of-stream to raise premature close error. Also noticed that _readableState.destroyed field is set to true.

Still trying to figure out why _readableState.ended is never set after calling destroy() on Readable stream. Is it right for end-of-stream to check _readableState.destroyed field?

[harishvadali]

Found that the fs Readable stream calls close in _destroy and the _readableState.ended is never set in that path.

https://github.com/nodejs/node/blob/v8.9.3/lib/fs.js#L2057