WIP: Add audit method to fix corrupted databases #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| function finish () { | ||
| var errs = results.map(r => r.err).filter(r => r) | ||
| if (errs.length) cb(errs, results) |
There was a problem hiding this comment.
Is it a good idea to pass the errors as array? Its against common convention of it being an Error instance.
|
@Frando I am wondering if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an audit method that calls hypercore's recently added audit method on all writers. It should remove corrupted blocks. Does not work currently because after an audit that resulted in the removal of a block the reported length of the hypercore is wrong. @mafintosh is working on a fix in hypercore for this.