-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Other parts of this protocol not supported #5
Comments
@wesleytodd I can't find any documentation on the difference between service and parent domains. Where did you find info on this? |
@wesleytodd I was reading that before but didn't really get that much wiser 😉 Reading it again now I think I interpret it like the following:
Is that how you interpret it as well? |
yes mostly, but my assumption was that |
Just re-read this from the RFC:
From this I gather that when using DNS-SD together with mDNS, the |
I think the algorithm for detecting this would be something like this:
|
Yep, didn't see that part, totally agree. So for something like this
So I tried getting |
Yes
Are you referring to the trailing period after "local"? I've been meaning to debug why that's not working. As you say the RFC is pretty clear on that so it should work. It could be a bug in the multicast-dns module - but for now I've just left it out since that seems to work ok without it. |
exactly what I did. Ok, probably this weekened I will take a look at my changes and make sure they incorporate these notes. Thanks! |
@wesleytodd I'll hopefully get through my backlog of issues and pull requests over the weekend as well 😄 |
Other PR coming your way:
There are three other parts of the dns service name not supported in this module:
Not currently supported:
The changes I was thinking of are as follows:
stringify
should take an object of the form:{instance: <String>, name: <String>, protocol: <String>, subtypes: <Array>, serviceDomain: <String>, parentDomain: <String>}
The subtypes is already a breaking change, so my thought is a 2.0 with this and the subtypes would be a good idea. Thoughts?
The text was updated successfully, but these errors were encountered: