-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for subtypes, serviceDomain, parentDomain and instance #6
base: master
Are you sure you want to change the base?
Conversation
I'll refer this to my local mdns advisor, @watson. |
2d625ac
to
88bc4ff
Compare
Ok, so some of the changes I made here are actually causing more changes for the PR to this: watson/bonjour#1 If @watson is alright with that that it will be alright to merge this, but lets wait on this until I can integrate there and @watson approves, sound good? :) |
@wesleytodd The If a service have two sub-types it should be advertised as 3 different PTR records. E.g. a tcp http service Named Foo with the subtypes "Bar" and "Baz" will generate the following PTR records:
So a single record do never contain all of the sub-types. |
@watson Totally forgot about that conversion we had. Agreed and will add that to my list of changes! |
@wesleytodd ups, messed up the PTR records above - the instance name is of cause not part of the PTR record names. I've updated the comment to show the full PTR records |
@wesleytodd the general rule is that you should be able to take the output Also,
Am I missing something? |
See #2, #3, #5.
I tried to make this NOT a re-write, but clearly did not succeed :)
Let me know what you think!