Support uTP Connections #11
Conversation
Enable support for connecting to peers using the uTP protocol
| }); | ||
| }); | ||
| }) |
There was a problem hiding this comment.
Bugger, missed a ;. This is annoying me now...
|
Can we make the utp stuff opt-in? As in default behavior is the same as before but if you set If it turns out the utp stuff is really stable we could enable it per default |
|
Also this module badly needs some tests. If you are up for helping out with that let me know :) |
|
I did a lot of testing and in all my tests it worked almost perfectly. Managed to get over 15MB/s from uTorrent using it in torrent-stream. I'm also auditing the uTP module at the moment to bring it more up to spec 😄 |
|
Bam! Done 😄 |
|
Awesome. Last thing. Is the custom |
|
No, its there so you can tell the difference between a failed UDP connection and a gracious close. Because UDP has no concept of a connection the only way to count it as "failed" is waiting for it to timeout. If we listened on |
|
Can I bump this please? Would love to get this upstream so we can depend on the official npm module again! |
ghost
mentioned this pull request
|
Oh yay @mafintosh Thanks :) |
|
Released in 0.10.0. I simplified the code a little bit. Could you test it out? |
|
(sorry about the delay - forgot about this pr) |
|
I left a comment on the commit. I could be wrong, but it looks to me as if it emits |
|
@mafintosh whats current status on this? |
Will attempt a uTP connection and then fallback to a normal connection if it seems like the peer doesn't support it or the connection times out.