Fix header decoding sometimes failing in the browser #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great find, thanks |
FrederikBolding
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Jan 19, 2024
## **Description** `tar-stream` has a bug where it randomly fails to decode tar headers due to mixing of `Uint8Array` and polyfilled `Buffer`. I have upstreamed a fix for this, but while we wait for it to be released, this patch should fix the issue! Context on the bug: mafintosh/tar-stream#164
You're welcome! I will admit, it took a while to track this one down 😅 If you could let me know once a new version is published, that would be much appreciated! That'll let me remove some patches 😅 |
|
Done, 3.1.7 |
|
Appreciate it, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Header decoding would sometimes fail in the browser due to mixing of polyfilled
BufferandUint8Array. I found two instances of callingtoString()directly on aUint8Arrayeventually leading to the checksum failing. This would happen semi-rarely based on the performance of the stream writing totar-stream.I have replaced the
toString()calls with usage ofb4a.