Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to GitHub Actions #46

Merged
merged 10 commits into from
Oct 24, 2020
Merged

Switch to GitHub Actions #46

merged 10 commits into from
Oct 24, 2020

Conversation

mafredri
Copy link
Owner

@mafredri mafredri commented Oct 22, 2020

This is not the ideal way to use actions, we're building Zsh on each test. But Travis has basically given up on life so this will serve as a quick fix.

@mafredri mafredri force-pushed the github-actions branch 4 times, most recently from ffd8af9 to 647c947 Compare October 23, 2020 18:54
@mafredri
Copy link
Owner Author

mafredri commented Oct 23, 2020

It seems tests are failing on GitHub actions in a way that's not reproducible for me anywhere else. Can't figure it out 😞.

There seems to have been some issue with how GitHub actions runs the terminal, probably related to interactive-mode. For some reason some of the tests failed because of this.

For now, the test runner is force into interactive mode by running it via script. Seems to have solved the issue.

@mafredri mafredri force-pushed the github-actions branch 4 times, most recently from 8e46a95 to 1c6825d Compare October 24, 2020 16:07
@mafredri mafredri force-pushed the github-actions branch 2 times, most recently from 4e42592 to ff42f40 Compare October 24, 2020 16:37
@mafredri mafredri force-pushed the github-actions branch 2 times, most recently from 15f327a to 2607b65 Compare October 24, 2020 16:44
@mafredri mafredri merged commit 65c0885 into master Oct 24, 2020
@mafredri mafredri deleted the github-actions branch October 24, 2020 17:00
mafredri added a commit that referenced this pull request Oct 24, 2020
* Add github test action

* Remove .travis.yml

* Force interactive zsh on GH Actions

* Enable all previous versions of zsh

* Fix build for zsh 5.0.x

* test: Disable sigwinch test on zsh 5.0.2

* test: Decrease stress test flakyness

* Try to fix signals for zsh 5.0.2?

* Revert "Try to fix signals for zsh 5.0.2?"

* Ok, fine, bye bye 5.0.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant