Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify functions for jobs must be defined when worker is started #53

Merged
merged 4 commits into from
Mar 3, 2021

Conversation

von
Copy link
Contributor

@von von commented Feb 28, 2021

Per discussion in #17

Copy link
Owner

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a few small suggestions but other than that it looks great, thanks!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
von and others added 3 commits February 28, 2021 15:29
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
@von
Copy link
Contributor Author

von commented Feb 28, 2021

Had a few small suggestions but other than that it looks great, thanks!

@mafredri Changes made per your suggestions.

@mafredri mafredri merged commit a61239d into mafredri:master Mar 3, 2021
@mafredri
Copy link
Owner

mafredri commented Mar 3, 2021

Thanks @von!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants