-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sleep duration that configurable via ENV #67
base: main
Are you sure you want to change the base?
Add sleep duration that configurable via ENV #67
Conversation
This sleep duration will be used to give a leeway time for some terminals that haven't loaded all the necessary scripts when the async job is being dispatched. In some cases, it will make the async job not working properly or even not running at all. We set the default sleep duration as `0` to keep backward compatibility with the previous version and it can be changed through ENV.
039c857
to
c4acc73
Compare
@mafredri I will glad to hear the follow up from you |
Hi, it's a bit unclear to me in what situations this can help, could you give an example? Delaying the async job here won't change the environment since async jobs are started in a sub shell, so I'm thinking the issue must be something else. |
Here is a better explanation for this spaceship-prompt/spaceship-prompt#1193 (comment) |
Hey @mafredri, I am a @spaceship-prompt maintainer. I've described the problem over here: #58 We dug down to the bottom of this issue, and it seems like this can resolve the issue. |
I tested these changes on my server machine. Seems like the delay of |
i can confirm i'm still experiencing the issue with spaceship on WSL2, so this fix would still be appreciated, at least until an underlying cause can be found/fixed. |
This sleep duration will be used to give a leeway time for some terminals that haven't loaded all the necessary scripts when the async job is being dispatched. In some cases, it will make the async job not working properly or even not running at all.
We set the default sleep duration as
0
to keep backward compatibility with the previous version and it can be changed through ENV.This is also a follow up to #58