Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CloudSQL Chart incorrect set replicas when autoscaler is enabled #3237

Closed
t83714 opened this issue Oct 7, 2021 · 1 comment
Closed

CloudSQL Chart incorrect set replicas when autoscaler is enabled #3237

t83714 opened this issue Oct 7, 2021 · 1 comment
Labels
bug
Milestone
v1.0.0

Comments

@t83714
Copy link
Contributor

t83714 commented Oct 7, 2021

Describe the bug
A clear and concise description of what the bug is.

This line:

magda/deploy/helm/internal-charts/cloud-sql-proxy/templates/deployment.yaml

Lines 8 to 10 in 71452c8

{{- if .Values.autoscaler.enabled }}
replicas: {{ .Values.replicas | default 1 }}
{{- end }}

The logic should be reversed.

i.e. should be:

{{- if empty .Values.autoscaler.enabled }}

a workaround could be setting replicas to the same as the min. of autoscaler
@t83714 t83714 added the bug label Oct 7, 2021
@t83714 t83714 added this to the v1.0.0 milestone Oct 7, 2021
t83714 added a commit that referenced this issue Oct 9, 2021
@t83714
#3237 fixed CloudSQL Chart incorrect set replicas when autoscaler is …
5970055 
…enabled
@t83714 t83714 mentioned this issue Oct 10, 2021
Merged
2 tasks
@t83714
Copy link
Contributor Author

t83714 commented Oct 15, 2021

closed via PR #3240

@t83714 t83714 closed this as completed Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@t83714