Feature mage-os/generate-mirror-repo-js#75 integrity check improvement #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpodorozh
changed the title
vpodorozh
changed the title
|
This looks good, but I think we need to add a new CI pipeline workflow to test this against the preview mirror before we merge it. cc: @Vinai @DavidLambauer |
… optimized code
Vinai
requested changes
Sep 7, 2023
|
sum up - change request from @Vinai added. thank you! |
damienwebdev
requested changes
Sep 7, 2023
.github/workflows/integrity-check-package-versions-validate.yml
Outdated
Show resolved
Hide resolved
|
Hi Damien!I didn’t got it mate - have too many questions 😅Discord tomorrow?
|
|
Sure! |
Vinai
approved these changes
Sep 8, 2023
mage-os-ci
added a commit
that referenced
this pull request
Sep 18, 2023
* feat: Add coding standard and mftf (#82) * Remove obsolete comment * feat: activate missing coding-standard and mftf repo * feat: Add magento/composer package to mirror build config (#83) * Remove obsolete comment * feat: activate missing coding-standard and mftf repo * feat: enable magento/composer packages to be built * feat: add coding standard and mftf to upstream-nightly builds (#84) * feat: add coding-standard and mftf to upstream-nightly builds * Add coding standard and mftf to mageos nightly (#85) * feat: add coding-standard and mftf mageos-nightly builds * chore: update develop branch to include latest changes merged directly into main (#93) * Remove obsolete comment * feat: Add generator version number to Satis HTML * fix: satis build via GitHub workflow (#88) * fix: satis build missing template with generator version * feat: add releases 2.4.4-p5, 2.4.5-p4 and 2.4.6-p2 (#89) feat: add upstream releases 2.4.4-p5, 2.4.5-p4 and 2.4.6-p2 * fix: exclude .gitignore from 245p4 246p2 base package (#90) * chore: exclude .gititnore from 2.4.5-p4 and 2.4.6-p2 base package * fix: exclude .gitignore from 244p5 base package * chore: exclude .gititnore from 2.4.4-p5 base package --------- Co-authored-by: callum-zero1 <callum.breeze@zero1.co.uk> * feat: implement mage-os release build process (#92) * [feat] implement building upstream version map * feat: start outlining build process in code (WIP) * feat(wip): install sample data for creating the upstream version map * feat: finalize sample data in upstream version map (wip) * feat(wip): Preparation of child package composer.json files, add --ignore-platform-reqs to Composer commands, changes to packages-config, start work to checkout work-in-progress branches. * feat(wip): Preparation of child package composer.json files, add --ignore-platform-reqs to Composer commands, changes to packages-config, start work to checkout work-in-progress branches. * feat (wip): Further improvements to last commit - remove .git from packages-config, re-order Composer command arguments, rename Git create branch function * Add .editorconfig * chore: Correct code formatting * feat: start implementing product-community-edition meta-package (wip) * Implement code to build mage-os/product-community-edition package * Set version of dependencies for mage-os packages to release version * Generate packages from prepared release branch (WIP) * Memoize working copy state to speed up build process * Extract build config merging to allow adding key/values to individual instructions * Generate meta packages from directories using the mage-os vendor name * Prep and build project metapackage (WIP) * Add config for missing packages (disabled until repos exist) * Remove obsolete comment * chore: add new upstream repos to configs * fix: use correct source ref when creating a branch * - feat: Add generator version number to Satis HTML * fix: satis build via GitHub workflow (#88) * fix: satis build missing template with generator version * Make release vendor name a command argument * chore: update readme with latest changes * feat: add new command options to generate a release * docs: add overview how to create custom releases * chore: tweak wip-branch name * feat: add releases 2.4.4-p5, 2.4.5-p4 and 2.4.6-p2 (#89) feat: add upstream releases 2.4.4-p5, 2.4.5-p4 and 2.4.6-p2 * fix: exclude .gitignore from 245p4 246p2 base package (#90) * chore: exclude .gititnore from 2.4.5-p4 and 2.4.6-p2 base package * fix: exclude .gitignore from 244p5 base package * chore: exclude .gititnore from 2.4.4-p5 base package * feat: add github workflow to build and deploy a mage-os release * chore: improve labels to be more clear --------- Co-authored-by: callum-zero1 <callum.breeze@zero1.co.uk> Co-authored-by: Mage-OS <100189073+mage-os-ci@users.noreply.github.com> * fix: repair mirror builds (#94) * [feat] implement building upstream version map * feat: start outlining build process in code (WIP) * feat(wip): install sample data for creating the upstream version map * feat: finalize sample data in upstream version map (wip) * feat(wip): Preparation of child package composer.json files, add --ignore-platform-reqs to Composer commands, changes to packages-config, start work to checkout work-in-progress branches. * feat(wip): Preparation of child package composer.json files, add --ignore-platform-reqs to Composer commands, changes to packages-config, start work to checkout work-in-progress branches. * feat (wip): Further improvements to last commit - remove .git from packages-config, re-order Composer command arguments, rename Git create branch function * Add .editorconfig * chore: Correct code formatting * feat: start implementing product-community-edition meta-package (wip) * Implement code to build mage-os/product-community-edition package * Set version of dependencies for mage-os packages to release version * Generate packages from prepared release branch (WIP) * Memoize working copy state to speed up build process * Extract build config merging to allow adding key/values to individual instructions * Generate meta packages from directories using the mage-os vendor name * Prep and build project metapackage (WIP) * Add config for missing packages (disabled until repos exist) * Remove obsolete comment * chore: add new upstream repos to configs * fix: use correct source ref when creating a branch * feat: Add generator version number to Satis HTML * fix: satis build via GitHub workflow (#88) * fix: satis build missing template with generator version * Make release vendor name a command argument * chore: update readme with latest changes * feat: add new command options to generate a release * docs: add overview how to create custom releases * chore: tweak wip-branch name * feat: add releases 2.4.4-p5, 2.4.5-p4 and 2.4.6-p2 (#89) * feat: add upstream releases 2.4.4-p5, 2.4.5-p4 and 2.4.6-p2 * fix: exclude .gitignore from 245p4 246p2 base package (#90) * chore: exclude .gititnore from 2.4.5-p4 and 2.4.6-p2 base package * fix: exclude .gitignore from 244p5 base package * chore: exclude .gititnore from 2.4.4-p5 base package * feat: add github workflow to build and deploy a mage-os release * chore: improve labels to be more clear * Fix mirror builds after changes to composer.json template path for releases --------- Co-authored-by: callum-zero1 <callum.breeze@zero1.co.uk> * fix: add missing inputs to step arguments (#96) * [feat] implement building upstream version map * feat: start outlining build process in code (WIP) * feat(wip): install sample data for creating the upstream version map * feat: finalize sample data in upstream version map (wip) * feat(wip): Preparation of child package composer.json files, add --ignore-platform-reqs to Composer commands, changes to packages-config, start work to checkout work-in-progress branches. * feat(wip): Preparation of child package composer.json files, add --ignore-platform-reqs to Composer commands, changes to packages-config, start work to checkout work-in-progress branches. * feat (wip): Further improvements to last commit - remove .git from packages-config, re-order Composer command arguments, rename Git create branch function * Add .editorconfig * chore: Correct code formatting * feat: start implementing product-community-edition meta-package (wip) * Implement code to build mage-os/product-community-edition package * Set version of dependencies for mage-os packages to release version * Generate packages from prepared release branch (WIP) * Memoize working copy state to speed up build process * Extract build config merging to allow adding key/values to individual instructions * Generate meta packages from directories using the mage-os vendor name * Prep and build project metapackage (WIP) * Add config for missing packages (disabled until repos exist) * Remove obsolete comment * chore: add new upstream repos to configs * fix: use correct source ref when creating a branch * - feat: Add generator version number to Satis HTML * fix: satis build via GitHub workflow (#88) * fix: satis build missing template with generator version * Make release vendor name a command argument * chore: update readme with latest changes * feat: add new command options to generate a release * docs: add overview how to create custom releases * chore: tweak wip-branch name * feat: add releases 2.4.4-p5, 2.4.5-p4 and 2.4.6-p2 (#89) feat: add upstream releases 2.4.4-p5, 2.4.5-p4 and 2.4.6-p2 * fix: exclude .gitignore from 245p4 246p2 base package (#90) * chore: exclude .gititnore from 2.4.5-p4 and 2.4.6-p2 base package * fix: exclude .gitignore from 244p5 base package * chore: exclude .gititnore from 2.4.4-p5 base package * feat: add github workflow to build and deploy a mage-os release * chore: improve labels to be more clear * Fix mirror builds after changes to composer.json template path for releases * fix: add missing inputs to step arguments --------- Co-authored-by: callum-zero1 <callum.breeze@zero1.co.uk> * fix: typo in compute-release-service-versions (#97) * [feat] implement building upstream version map * feat: start outlining build process in code (WIP) * feat(wip): install sample data for creating the upstream version map * feat: finalize sample data in upstream version map (wip) * feat(wip): Preparation of child package composer.json files, add --ignore-platform-reqs to Composer commands, changes to packages-config, start work to checkout work-in-progress branches. * feat(wip): Preparation of child package composer.json files, add --ignore-platform-reqs to Composer commands, changes to packages-config, start work to checkout work-in-progress branches. * feat (wip): Further improvements to last commit - remove .git from packages-config, re-order Composer command arguments, rename Git create branch function * Add .editorconfig * chore: Correct code formatting * feat: start implementing product-community-edition meta-package (wip) * Implement code to build mage-os/product-community-edition package * Set version of dependencies for mage-os packages to release version * Generate packages from prepared release branch (WIP) * Memoize working copy state to speed up build process * Extract build config merging to allow adding key/values to individual instructions * Generate meta packages from directories using the mage-os vendor name * Prep and build project metapackage (WIP) * Add config for missing packages (disabled until repos exist) * Remove obsolete comment * chore: add new upstream repos to configs * fix: use correct source ref when creating a branch * feat: Add generator version number to Satis HTML * fix: satis build via GitHub workflow (#88) * fix: satis build missing template with generator version * Make release vendor name a command argument * chore: update readme with latest changes * feat: add new command options to generate a release * docs: add overview how to create custom releases * chore: tweak wip-branch name * feat: add releases 2.4.4-p5, 2.4.5-p4 and 2.4.6-p2 (#89) * feat: add upstream releases 2.4.4-p5, 2.4.5-p4 and 2.4.6-p2 * fix: exclude .gitignore from 245p4 246p2 base package (#90) * chore: exclude .gititnore from 2.4.5-p4 and 2.4.6-p2 base package * fix: exclude .gitignore from 244p5 base package * chore: exclude .gititnore from 2.4.4-p5 base package * feat: add github workflow to build and deploy a mage-os release * chore: improve labels to be more clear * Fix mirror builds after changes to composer.json template path for releases * fix: add missing inputs to step arguments * fix: typo in compute-release-service-versions --------- Co-authored-by: callum-zero1 <callum.breeze@zero1.co.uk> * Feature #75 integrity check improvement (#101) * #75 add integrity check * #75 - fixes from stupid Squirrel * #75 - add suggest, replace, conflict sections in checklist and optimized code * #75 create new workflow * #75 create new workflow * #75 fix coderview points from Vinai * #75 merge old and new integrity checks with Vinai * #75 remove unneded dependencies * #75 add npm install (#103) * #75 remove chalk for integrity checker… (#104) * #75 remove chalk for integrity checker - minimise dependencies * #75 add ignoring of .git folder * feat: fix version discrepancies between public github repos and published packages from adobe (#105) * fix: adjust more version discrepancies between public github repos and published packages from adobe (#106) * fix: tags with -dev suffix generate incompatible nightly version (#107) * fix: tags with -dev suffix generate incompatible nightly version keeping stability at alpha (#108) * fix: tags with -dev suffix generate incompatible nightly version keeping stability at alpha (#109) * Fix docker image build for current PHP ext installer version and git (#112) * fix: install npm in image to install generator deps (#113) * Fix docker image build for current PHP ext installer version and git * fix: install npm in image to pull in generator deps * chore: resolve conflicts with main branch (#114) * feat: fix mirror packages composer.json to match upstream (#110) Also repair nightly builds * feat: fix mirror package checksums (#111) This MR fixes the mirror package composer.json version constraints as well as upstream and mage-os nightly generation. --------- Co-authored-by: callum-zero1 <callum.breeze@zero1.co.uk> Co-authored-by: Vladyslav Podorozhnyi <vpodorozh@gmail.com> --------- Co-authored-by: callum-zero1 <callum.breeze@zero1.co.uk> Co-authored-by: Vladyslav Podorozhnyi <vpodorozh@gmail.com> * fix: resolve merge conflict with main (#116) * feat: fix mirror packages composer.json to match upstream (#110) Also repair nightly builds * feat: fix mirror package checksums (#111) This MR fixes the mirror package composer.json version constraints as well as upstream and mage-os nightly generation. --------- Co-authored-by: callum-zero1 <callum.breeze@zero1.co.uk> Co-authored-by: Vladyslav Podorozhnyi <vpodorozh@gmail.com> --------- Co-authored-by: callum-zero1 <callum.breeze@zero1.co.uk> Co-authored-by: Vladyslav Podorozhnyi <vpodorozh@gmail.com> --------- Co-authored-by: callum-zero1 <callum.breeze@zero1.co.uk> Co-authored-by: Mage-OS <100189073+mage-os-ci@users.noreply.github.com> Co-authored-by: Vladyslav Podorozhnyi <vpodorozh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #75
Introduce integrity-test script that does checks over
require,require-dev,suggest,replaceandconflictsections for packages and performs a comparison between mage-os preview mirror and magento .Example diff output:
