Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AddThis template and configuration #25

Merged
merged 1 commit into from
May 31, 2016
Merged

AddThis template and configuration #25

merged 1 commit into from
May 31, 2016

Conversation

andreygolovin
Copy link

Hello, thanks for great module.

Please check this PR if you will have some time:

  1. AddThis JS init code moved to template
  2. AddThis admin configuration added

@pivulic
Copy link

pivulic commented May 31, 2016

👍

@magefan magefan merged commit 224607a into magefan:master May 31, 2016
@magefan
Copy link
Owner

magefan commented May 31, 2016 •
edited
Loading

@andreygolovin thank you for your contribution to Magento Blog!

@pivulic
Copy link

pivulic commented Jun 1, 2016

Can you also release a new version in https://packagist.org/packages/magefan/module-blog, e.g. 2.2.1?

@magefan
Copy link
Owner

magefan commented Jun 1, 2016

@pivulic, yes sure. (https://github.com/magefan/module-blog/releases/tag/2.2.1)

@pivulic
Copy link

pivulic commented Jun 3, 2016

As usual, thanks for the quick help!

@r0umi r0umi mentioned this pull request Feb 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreygolovin @pivulic @magefan