Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asdf installation instructions to docs #383

Merged
merged 4 commits into from
Nov 1, 2021

Conversation

mathew-fleisch
Copy link
Contributor

The asdf version manager is a tool for installing release binaries from Github. With asdf installed, the asdf plugin for mage can be used to install any released version of mage.

Please let me know if there is anything else I can do for this PR.

PS: Also willing to transfer ownership of the plugin if that is desirable to the community

Copy link
Member

@natefinch natefinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Can you shorten it up a bit? :)

site/content/index.md Outdated Show resolved Hide resolved
site/content/index.md Outdated Show resolved Hide resolved
mathew-fleisch and others added 2 commits November 1, 2021 08:48
Co-authored-by: Nate Finch <natefinch@github.com>
Copy link
Member

@natefinch natefinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@natefinch natefinch merged commit 0c5affe into magefile:master Nov 1, 2021
@sheldonhull
Copy link

@natefinch can we get this transferred to the magefile org? This is really useful for projects and would be good to know the regular test suite runs. The test case is already documented too.

@mathew-fleisch
Copy link
Contributor Author

I'm fine with that. Other than copying the repo to the mage org, we'd also need to update the asdf-plugins repo to point at the new location.

@natefinch
Copy link
Member

I'm not entirely sure that asdf is even really needed for mage. It says it's intended to manage different versions of tools, but mage is 100% backwards compatible, so you don't need to manage versions, you can always just get latest and it'll work with any mage script ever written.

@mathew-fleisch
Copy link
Contributor Author

mathew-fleisch commented Mar 26, 2022

it's probably not "needed" 😏 but the reason I love to manage tools with asdf is it provides a standard way of installing binaries from a CI pov, that theoretically works on multiple system architectures. For instance, this tool is a github-action linter written in rust and I install the last stable version with asdf on commits to any PR to ensure changes to any other action conforms to standards. https://i.imgflip.com/6a48ie.jpg
https://github.com/mathew-fleisch/action-validator/blob/test-self-hosted/.github/workflows/self-hosted-example.yml#L23-L33

I don't personally regularly use mage, and I cannot remember why I originally made this plugin 🤔 , but someone might want to do the same and I'll transfer ownership if desired 🤷

Also happy to continue "maintaining" this plugin, but there haven't been any PRs yet.

@natefinch
Copy link
Member

That's funny that you're not even using Mage. Sheldon, do you want to take over, since you actually do use it? I know the burden of maintaining stuff that you don't even use.

@sheldonhull
Copy link

@natefinch be more than happy to help where I can. I've been meaning to explore creating an asdf plugin but hadn't yet. I actually do most of my installs in mage tasks now 😆 and avoid bash scripting where I can. I'll have to getfamiliarr with the asdf one.

@sheldonhull
Copy link

I'm not entirely sure that asdf is even really needed for mage. It says it's intended to manage different versions of tools, but mage is 100% backwards compatible, so you don't need to manage versions, you can always just get latest and it'll work with any mage script ever written.

To be fair I prefer go install for mage, as it's ok to not have the commit info for me mostly.
That said, the point of asdf is that common tools are just easy to immediately access.

The versioning is a perk, but running on latest is also totally fine.
It just makes it quick and simple to setup a container or project with all the tooling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants