Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple copies of Nadu's ability don't have independent trigger limits #12484

Open
Grath opened this issue Jun 17, 2024 · 5 comments
Open

Multiple copies of Nadu's ability don't have independent trigger limits #12484

Grath opened this issue Jun 17, 2024 · 5 comments

Comments

@Grath
Copy link
Contributor

Grath commented Jun 17, 2024

Per MH3 Release Notes, each copy of Nadu's ability needs to count the trigger limit independently (also applicable if you flicker Nadu to refresh the ability):

If you somehow control more than one Nadu, each permanent you control will have that many instances of the granted ability. These abilities are not redundant. For example, if you control two Nadus and one becomes the target of a spell or ability, each of its granted abilities will trigger. If that same Nadu becomes the target of a spell or ability again later in the turn, each of its granted abilities will trigger again, as each of them have triggered only once so far this turn.

If Nadu leaves the battlefield and returns to the battlefield in the same turn, or if Nadu leaves and another Nadu appears, the triggered ability granted by the new one is different than the triggered ability granted by the old one. The one granted by the new Nadu may trigger twice for each creature you control, even if the ability granted by the old Nadu already triggered twice for those creatures that turn. (Note that creatures you control won't have the ability granted by the old one anymore, and if you control multiple Nadus, you won't have the opportunity to take actions before the "legend rule" gets you down to one Nadu.)

@Grath
Copy link
Contributor Author

Grath commented Jun 17, 2024

[[Nadu, Winged Wisdom]]

Copy link

Nadu, Winged Wisdom - (Gatherer) (Scryfall) (EDHREC)

{1}{G}{U}
Legendary Creature — Bird Wizard
3/4
Flying
Creatures you control have "Whenever this creature becomes the target of a spell or ability, reveal the top card of your library. If it's a land card, put it onto the battlefield. Otherwise, put it into your hand. This ability triggers only twice each turn."

@Susucre
Copy link
Contributor

Susucre commented Jun 22, 2024

Uhm so the setup of keys for setting the trigger count is not quite right:

image

This is strange, because the comment on the CardUtil's method seems to indicate it should work properly on zcc change (i.e. different key):

image

@Susucre
Copy link
Contributor

Susucre commented Jun 22, 2024

Maybe the issue is with getOriginalId() instead of getId()?
Not actually sure what is the purpose of originalId (that was already the setup before adding support for Nadu). And seems i'm not alone on the sentiment it feels weird:

image

@JayDi85
Copy link
Member

JayDi85 commented Jun 22, 2024

OriginalId used for linked abilities (it allows to check is it same ability or from another card/object). OriginalId is same for whole ability lifecycle, even after activate (example: multiple shield instances will have same originalId, but unique id — same for multiple activates of the same ability). Xmage creates full copy of the ability with new id and old original id on each activate.

Maybe some copy code miss of the newOriginalId or assignNewId calls. Or maybe it’s a breaking fix:

  • if you assign new originalId on new card then will lost linked abilities/effects (effects with getOriginalId will be broken);
  • if you do NOT assign new originalId on new card then will lost unique instances and get bugs like current issue;

IMG_0549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants