Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in progress attempt at fixing Nadu in edge scenarios #12548

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Susucre
Copy link
Contributor

@Susucre Susucre commented Jun 30, 2024

This is far from done. But I'd rather have other devs opinions at this point.

Issue that I try to fix here is that [[Nadu, Winged Wisdom]]'s limit on 2 per permanent is reliant on the given ability originalId, and that id stays the same if casting Ephemerate on Nadu, or copying Nadu, which incorrectly prevents the ability to trigger in various situations.

The work in progress is at the moment working for Ephemerate, multiple real Nadu, but is not yet working if copying Nadu with a Clone (may add a test on making a token copy too). Issue being the originalIds preserved in the GainAbilityControlledEffect gets reset each time the clone's ability are added (which is quite often).

I'm not yet 100% sure of at which degree the originalId should be preserved along the copy/addAbility chains, but once I'm happy with Nadu, the changes done should be also done in similar continuous effects.

#12484 for reference on the issue.

Copy link

Nadu, Winged Wisdom - (Gatherer) (Scryfall) (EDHREC)

{1}{G}{U}
Legendary Creature — Bird Wizard
3/4
Flying
Creatures you control have "Whenever this creature becomes the target of a spell or ability, reveal the top card of your library. If it's a land card, put it onto the battlefield. Otherwise, put it into your hand. This ability triggers only twice each turn."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant