Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add lands after draft portion of limited tournament #13127

Closed
radiasian opened this issue Dec 10, 2024 · 7 comments
Closed

Cannot add lands after draft portion of limited tournament #13127

radiasian opened this issue Dec 10, 2024 · 7 comments
Assignees
Labels
bug Bugs and errors

Comments

@radiasian
Copy link

I clicked the "lands" button and got this:

Error type: CLIENT - unhandled error in GUI - IllegalArgumentException
Client version: 1.4.55-V2 (build: 2024-12-01 17:48)

No set with basic land was found

Stack trace:
mage.client.dialog.AddLandDialog.showDialog(AddLandDialog.java:90)
mage.client.deckeditor.DeckEditorPanel.btnAddLandActionPerformed(DeckEditorPanel.java:1490)
mage.client.deckeditor.DeckEditorPanel.access$900(DeckEditorPanel.java:51)
mage.client.deckeditor.DeckEditorPanel$11.actionPerformed(DeckEditorPanel.java:1213)
javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022)
javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2348)
javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402)
javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:252)
java.awt.Component.processMouseEvent(Component.java:6539)
and other 30 lines

restarting the client without closing the initial client fixed the issue.

@xenohedron
Copy link
Contributor

We've had several reports of similar errors. The sets being drafted do have basic lands, it works fine for most players. Not sure what might be the root cause.

@JayDi85
Copy link
Member

JayDi85 commented Dec 10, 2024

@radiasian are you having slow connection or disconnects while playing xmage?

@xenohedron
Copy link
Contributor

got another today
image

does seem to be related to connection hiccups somehow

@JayDi85
Copy link
Member

JayDi85 commented Dec 14, 2024

Looks like there are two places with related code and potential buggy use cases (only theory):

  • server side error with tourney freeze (see next comments):
    • play in non-test mode with deck validation or run with -Dxmage.testMode=false
    • draft with sets without lands, do not add lands manually on construction and wait timeout
    • tourney must freeze
  • client side error (see next comments):
    • draft with sets without lands and try to press add lands button on construction;

shot_241214_094501

I'm not sure how to run drafts with such sets without lands. Maybe some supplemental sets affected (some supplemental sets must take lands from a parent set, see related #10184).

P.S. There is possible a server side error with memory overflow and broken database -- so it can't find any lands or other cards. If you catch that land errors before server restart then it's a real reason.

P.P.S. Error is not related to miss lands button from other issues like #12731

@JayDi85 JayDi85 added the bug Bugs and errors label Dec 14, 2024
@JayDi85
Copy link
Member

JayDi85 commented Dec 14, 2024

Fast alternative solution -- if deck haven't sets with lands then use all possible sets/lands. It's compatible with mtg rules.

@JayDi85 JayDi85 self-assigned this Dec 14, 2024
@JayDi85
Copy link
Member

JayDi85 commented Dec 14, 2024

After some research -- client side error from topic starter related to memory problems on local machine. There are impossible any use cases with empty sets list on the client except memory:
shot_241215_002725

So potential server side error on timeout is under investigation.

@JayDi85
Copy link
Member

JayDi85 commented Dec 16, 2024

Server side error can be catched on server's memory problems only (after database corruption). There are not any workable use cases in normal situation. Added related tests in 2955535 So topic can be closed.

@JayDi85 JayDi85 closed this as completed Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs and errors
Projects
None yet
Development

No branches or pull requests

3 participants