WIP: Allow objects to have multiple names #12839
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xenohedron
reviewed
Sep 14, 2024
| return false; | ||
| } | ||
| return CardUtil.haveSameNames(card, creatureName, game) && Objects.equals(ownerId, card.getOwnerId()); | ||
| return spellAbility != null && card != null && card.isOwnedBy(ownerId) && card.sharesName(creature, game); |
There was a problem hiding this comment.
need to null check spell ability before calling getCharacteristics
JayDi85
reviewed
Sep 14, 2024
| boolean hasName(String name, Game game); | ||
|
|
||
| default boolean sharesName(MageObject mageObject, Game game) { | ||
| return !mageObject.getName().isEmpty() && hasName(mageObject.getName(), game); |
There was a problem hiding this comment.
Make sure you don’t use empty string logic for names, it’s fail in equal code (face down cards with empty names are not equal, but strings are). Use !CardUtil.haveEmptyName instead string.isEmpty()
The main idea behind old code with haveSameName and haveEmptyName:
- protect from empty string compare errors (see above);
- support diff object types in diff zones due diff naming rules (see commented tests with use cases in test_NamesEquals);
- introduce independent from empty strings in object names (e.g. it can have any value for GUI or other purpose and fully support of mtg rules).
There was a problem hiding this comment.
yeah I'm gonna make sure I handle that all correctly, this is basically just placeholder code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just need to get this one started already, closes #12805