massacre girl fixed to correctly proc -1/-1 on creature death #13104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand what this change would affect. It seems to me that the linked issue is really due to the #13089 regression. Do you have a test case that works differently with this change? |
|
I didn't make a test case but upon trying massacre girl on some tokens it was not triggering the -1/-1 effect on creature death, so I referenced the implementation of checkTrigger for a similar card Death Frenzy . This did make it work as intended, but it's possible this is still caused by the issue you mentioned so perhaps this fix doesn't resolve the core of the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Massacre Girl
Partial fix of Issue #13101