Rain of riches fix #9785
Rain of riches fix #9785
Conversation
| @@ -1210,6 +1210,7 @@ public boolean cast(SpellAbility originalAbility, Game game, boolean noMana, App | |||
| castEvent.setZone(fromZone); | |||
| game.fireEvent(castEvent); | |||
| if (spell.activate(game, noMana)) { | |||
| game.applyEffects(); | |||
There was a problem hiding this comment.
It's a magic that can ruin game cycle at all. See comments from #8402 for game cycle details and applyEffects/processAction.
game.applyEffects() already called in spell.activate's code
Need more research and possible fix. I don't recommends to add applyEffects for any fixes without critical reason.
There was a problem hiding this comment.
I did end up changing this to game.getState().processAction(game); (see last commit). Please let me know if this is acceptable.
game.applyEffects() is already called in spell.activate's code, but this is before costs are paid. Please take a look at my comment in the linked issue (#9669) for details.
|
The latest CI failure seems to be because the snow-covered island in J22 isn't correctly listed as basic |
There was a problem hiding this comment.
@JayDi85 this one's been waiting for a while, could you explain what needs to be done?
|
I'll check tests on my local computer in the morning with a merged branch just to make sure everything is still working since I made this... wow a year ago. |
|
I re-ran the travis build and it passed |
|
Does Travis merge with master though? Or just runs tests in the branch itself? |
|
It runs a build against the merge commit. You should be able to see the details under the "Checks" tab. |
Fixes #9669.
Please see my comments in the linked issue. This change also makes static abilities checked after a player finishes casting a spell but before watchers and triggers are checked for the
SPELL_CASTevent.