Skip to content
This repository was archived by the owner on Apr 29, 2019. It is now read-only.

[MAGETWO-1802] Import of file with spaces in required attributes is allowed #30

Closed
piotrekkaminski opened this issue Nov 3, 2017 · 1 comment
Assignees
Milestone

Comments

@piotrekkaminski
Copy link
Contributor

From @piotrekkaminski on November 2, 2017 20:31

In case empty values (spaces) are specified for required attributes in import file (example: first name and last name), there is no validation error and import is done successfully. Though it's not possible to create a customer with empty first name and last name via admin interface.

Test data

email _website firstname group_id lastname
test_ifebgl@unknown-domain.com base 1

Preconditions

  1. Version 2.0

Steps to reproduce

  1. Open Backend -> System -> Import/Export -> Import
  2. Select Entity Type: Customers
  3. Select Import Behaviour: Append Complex Data
  4. Select Import Format Version: Magento 1.7 format
  5. Select test file
  6. Click Check Data button.

Expected result

validation error, messages "Required attribute 'firstname' has an empty value in rows: 1" and "Required attribute 'lastname' has an empty value in rows: 1" are shown

Actual result

validation successful, message "File is valid! To start import process press "Import" button" is shown

Note

The same issue exists for Magento 2.0 import format

Copied from original issue: magento/magento2#11975

@dmanners dmanners added this to the Phase 2 milestone Feb 13, 2018
pogster pushed a commit to pogster/import-export-improvements that referenced this issue Jun 17, 2018
…ation. Add check if the required attribute is not empty after trimming.
pogster pushed a commit to pogster/import-export-improvements that referenced this issue Jun 17, 2018
…ation. Add check if the required attribute is not empty after trimming.
pogster pushed a commit to pogster/import-export-improvements that referenced this issue Jun 17, 2018
…lready exist. They may refer to different fields and should all be recorded and output. Undo 1dd4b36.
pogster pushed a commit to pogster/import-export-improvements that referenced this issue Jun 30, 2018
…ation. Add check if the required attribute is not empty after trimming.
pogster added a commit to pogster/import-export-improvements that referenced this issue Jun 30, 2018
…lready exist. They may refer to different fields and should all be recorded and output.
pogster added a commit to pogster/import-export-improvements that referenced this issue Jun 30, 2018
…umn name so several columns in the same row may throw the same error and they can be distinguished.
pogster added a commit to pogster/import-export-improvements that referenced this issue Jun 30, 2018
…umn name so several columns in the same row may throw the same error and they can be distinguished.
pogster pushed a commit to pogster/import-export-improvements that referenced this issue Jun 30, 2018
…ation. Add check if the required attribute is not empty after trimming.
pogster added a commit to pogster/import-export-improvements that referenced this issue Jun 30, 2018
…umn name so several columns in the same row may throw the same error and they can be distinguished.
pogster added a commit to pogster/import-export-improvements that referenced this issue Jul 5, 2018
pogster added a commit to pogster/import-export-improvements that referenced this issue Jul 6, 2018
@dmanners
Copy link
Contributor

Thank you @pogster for PR #113 which has covered this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants