Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Index (table) for Default Stock after Inventory module is installed #122

Merged
merged 5 commits into from
Oct 6, 2017

Conversation

bartekszymanski
Copy link
Contributor

Description

Fixed Issues (if relevant)

  1. Create Index (table) for Default Stock after Inventory module is installed #119: Create Index (table) for Default Stock after Inventory module is installed

Manual testing scenarios

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

) {
$this->sourceRepository = $sourceRepository;
$this->sourceFactory = $sourceFactory;
$this->stockRepository = $stockRepository;
$this->stockFactory = $stockFactory;
$this->assignSourcesToStock = $assignSourcesToStock;
$this->dataObjectHelper = $dataObjectHelper;
$this->stockItemIndexer = $stockItemIndexer;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please fix naming of this function

    /**
     * Assign default stock to default source
     *
     * @return void
     */
    private function assignStockToSource()
    {
        $this->assignSourcesToStock->execute([1], 1);
    }

Because we assign Sources to Stock , not vice versa but function name is assignStockToSource

@maghamed maghamed merged commit 6d95bca into develop Oct 6, 2017
@maghamed maghamed deleted the install-create-index-table branch December 11, 2018 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants