Add Services for Default Stock manipulation #121
Conversation
bartekszymanski
changed the title
| */ | ||
| interface DefaultSourceRepositoryInterface | ||
| { | ||
| const DEFAULT_SOURCE= 1; |
There was a problem hiding this comment.
currently, we have a requirement to provide a description to all the constants declared,
because constant introduces public contract the same as the public method.
There was a problem hiding this comment.
But in this case, I propose to remove this constant and leave an interface method
DefaultSourceResolverInterface::getId(): int
in this case, somebody could customize it. For example, change ID of the default source/stock
Having constant - there is no such possibility
| * | ||
| * @api | ||
| */ | ||
| interface DefaultSourceRepositoryInterface |
There was a problem hiding this comment.
It's better not to call this service as Repository. We have a strict pattern for Repositories and which methods should be placed there.
Here you can read more about this rules - https://github.com/magento-engcom/msi/wiki/Service-Contracts#magento-repositories-basics
There was a problem hiding this comment.
In this case, I propose to rename service to
DefaultSourceResolverInterface::getId(): int
which will return Id of the default Source (in our case 1 )
| * | ||
| * @api | ||
| */ | ||
| interface DefaultStockRepositoryInterface |
[LYNX] Jquery upgrade compatibility changes
Description
Fixed Issues (if relevant)
Contribution checklist