This repository has been archived by the owner on Apr 29, 2019. It is now read-only.
Removed each() function usage
#31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihor-sviziev
suggested changes
Jan 31, 2018
| @@ -337,7 +337,8 @@ public function install($request) | |||
|
|
|||
| $this->log->log('Starting Magento installation:'); | |||
|
|
|||
| while (list(, list($message, $method, $params)) = each($script)) { | |||
| foreach ($script as $item) { | |||
| list($message, $method, $params) = [$item[0], $item[1], $item[2]]; | |||
There was a problem hiding this comment.
I'd like to simplify it just with
list($message, $method, $params) = $item;| @@ -336,7 +336,8 @@ public function testComponentPathsInRoot() | |||
| "If there are any component paths specified, then they must be reflected in 'replace' section" | |||
| ); | |||
| $flat = $this->getFlatPathsInfo(self::$rootJson['extra']['component_paths']); | |||
| while (list(, list($component, $path)) = each($flat)) { | |||
| foreach ($flat as $item) { | |||
| list($component, $path) = [$item[0], $item[1]]; | |||
There was a problem hiding this comment.
I'd like to simplify it just with
list($component, $path) = $item;
- Updated static test to check `each()` usage
buskamuza
approved these changes
Jan 31, 2018
ihor-sviziev
approved these changes
Jan 31, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Feb 1, 2018
ihor-sviziev
pushed a commit
to ihor-sviziev/magento2
that referenced
this pull request
Feb 1, 2018
Backport of PR magento-engcom/php-7.2-support#31 to 2.2-develop
4 tasks
magento-engcom-team
pushed a commit
that referenced
this pull request
Sep 11, 2018
…ry point for GraphQL
magento-engcom-team
pushed a commit
that referenced
this pull request
Sep 11, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Sep 11, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Sep 11, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Sep 11, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Sep 11, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Sep 11, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Sep 11, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Sep 11, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Sep 11, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Oct 13, 2018
- Merge Pull Request magento/bulk-api-ce#31 from magento/bulk-api-ce:async-delete - Merged commits: 1. 069aa1c 2. 694d219
magento-engcom-team
pushed a commit
that referenced
this pull request
Jan 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
each()function usageUpdated static test to check
each()usageFixed Issues
Contribution checklist