This repository has been archived by the owner on Apr 29, 2019. It is now read-only.
Made getAllOptions() and toOptionArray() compatible
#34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buskamuza
changed the title
toOptionArray() and toOptionArray() compatiblegetAllOptions() and toOptionArray() compatible
buskamuza
suggested changes
Feb 7, 2018
| */ | ||
| public function toOptionArray($noEmpty = false) | ||
| public function toOptionArray($noEmpty = false, $foregroundCountries = '') | ||
| { | ||
| $options = parent::toOptionArray($noEmpty); |
There was a problem hiding this comment.
Please add $foregroundCountries here in the call, it's supported by the parent.
There was a problem hiding this comment.
@buskamuza, done.
buskamuza
approved these changes
Feb 7, 2018
ihor-sviziev
suggested changes
Feb 8, 2018
| $item2, | ||
| ]); | ||
|
|
||
| $this->itemPriceRenderer->method('toHtml') |
There was a problem hiding this comment.
@joni-jones @buskamuza It looks like missing check that method toHtml will be called at least once
There was a problem hiding this comment.
@ihor-sviziev, this expects is redundant because if toHtml() won't be called the test will fail. "Price assertions" check this case.
magento-engcom-team
pushed a commit
that referenced
this pull request
Feb 8, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 4, 2018
[Backport] Use correct error message for duplicate error key in product import
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Issues
Changes for EE in the internal branch https://github.com/magento-mpi/magento2ee/tree/G%236
Contribution checklist