This repository has been archived by the owner on Apr 29, 2019. It is now read-only.
Replace ZF1 Zend_Feed with ZF2/3 Zend\Feed #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsche
force-pushed
the
update-zend-feed
branch
from
42306f1 to
ca1f795
Compare
buskamuza
suggested changes
Mar 13, 2018
| @@ -4,7 +4,7 @@ | |||
| "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file", | |||
There was a problem hiding this comment.
Please use composer update <package>=<version> instead of bare composer update. At least one issue I already observed is new version of zend-code behaves differently. We might do full upgrade as a separate task.
|
bbatsche
force-pushed
the
update-zend-feed
branch
from
ca1f795 to
b73d1c8
Compare
buskamuza
approved these changes
Mar 13, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Mar 15, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Jun 21, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Jun 21, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Jun 21, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Jun 21, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Jun 21, 2018
…-Category [architects] MAGETWO-92773: [GraphQL] Products cannot be fetched in parent/anchor category #89
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replacing ZF1 Zend_Feed with Zend\Feed allows us to eliminate it as a module from Zend framework, and opens up many other additional modules that were otherwise dependencies on it.
Fixed Issues (if relevant)
Contribution checklist