-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CYMK to RGB Conversion won't work when Magento Compiler is on #16
Comments
Afaik there is no advantage in using a compiler. But this is not my project, so I have no opinion in this. |
I know many sites that are using the compiler, and many sites that don't. Just trying to make it compatible with everyone no matter what benefits the compiler may bring. Besides, Submitted a PR #17. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Pull request #14 (@rbrown) introduced support for CYMK images by converting them to RGB so that an image resize will not cause an image to become inverted in color. However, it doesn't work for sites using the Magento compiler, because the use of
__DIR__
magic constant will point to[magento_root]/includes/src
, instead of where the ICC profiles currently live[magento_root]/app/code/community/Varien/Image/Adapter/
. The resulting resized image will still be inverted in color.Suggestion to put the ICC files in
[magento_root]/lib/FireGento/PerfectWatermarks/
.The text was updated successfully, but these errors were encountered: