Fixed CYMK to RGB conversion when Magento compiler is on #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a LICENSE.txt with OSL License. This fixes issue magento-hackathon#5
Conflicts: src/app/code/community/Varien/Image/Adapter/Imagemagic.php
Make thread limit configurable.
Add composer.json
And also improves consistency with - Varien_Image_Adapter_Gd2 from Magento 1 - Magento\Framework\Image\Adapter\ImageMagick from Magento 2
…size This fixes an issue you have when performing a crop after a resize.
Some of our images are in CMYK, when they're resized onto a different shape canvas, the canvas colour inverts when the colorspace is changed. This patch tries to convert the CMYK images to sRGB before compositing them. The conversion code was taken from http://php.net/manual/en/imagick.setimagecolorspace.php
Convert CYMK images to RGB
|
jasperthedummy, you might want to rebase this against magento-hackathon:master rather than :develop, I don't think :develop is being used, and this pull request includes lots of commits that are already on master. |
|
Alright, closing this PR and creating a new PR to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refering to Issue #16.