Skip to content

Commit

Permalink
Implemented MAGETWO-11122: Configurable Grids (magento#471)
Browse files Browse the repository at this point in the history
- fixed method phpdocs
  • Loading branch information
Zyava committed Feb 1, 2014
1 parent 4ccd440 commit 87c9601
Show file tree
Hide file tree
Showing 21 changed files with 59 additions and 165 deletions.
16 changes: 4 additions & 12 deletions app/code/Magento/Backend/Block/Catalog/Product/Tab/Container.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,39 +31,31 @@ class Container extends \Magento\Backend\Block\Template
{

/**
* Return Tab label
*
* @return string
* {@inheritdoc}
*/
public function getTabLabel()
{
return '';
}

/**
* Return Tab title
*
* @return string
* {@inheritdoc}
*/
public function getTabTitle()
{
return $this->getTabLabel();
}

/**
* Can show tab in tabs
*
* @return boolean
* {@inheritdoc}
*/
public function canShowTab()
{
return true;
}

/**
* Tab is hidden
*
* @return boolean
* {@inheritdoc}
*/
public function isHidden()
{
Expand Down
16 changes: 4 additions & 12 deletions app/code/Magento/Backend/Block/Widget/Tab.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,39 +29,31 @@
class Tab extends \Magento\Backend\Block\Template implements TabInterface
{
/**
* Return Tab label
*
* @return string
* {@inheritdoc}
*/
public function getTabLabel()
{
return $this->getLabel();
}

/**
* Return Tab title
*
* @return string
* {@inheritdoc}
*/
public function getTabTitle()
{
return $this->getTitle();
}

/**
* Can show tab in tabs
*
* @return boolean
* {@inheritdoc}
*/
public function canShowTab()
{
return $this->hasCanShow() ? (bool) $this->getCanShow() : true;
}

/**
* Tab is hidden
*
* @return boolean
* {@inheritdoc}
*/
public function isHidden()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,7 @@ public function getAccordionHtml()
}

/**
* Tab is hidden
*
* @return boolean
* {@inheritdoc}
*/
public function canShowTab()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,29 +34,23 @@ abstract class AbstractTab
implements \Magento\Backend\Block\Widget\Tab\TabInterface
{
/**
* Return Tab label
*
* @return string
* {@inheritdoc}
*/
public function getTabLabel()
{
return $this->getTabTitle();
}

/**
* Can show tab in tabs
*
* @return boolean
* {@inheritdoc}
*/
public function canShowTab()
{
return true;
}

/**
* Tab is hidden
*
* @return boolean
* {@inheritdoc}
*/
public function isHidden()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,7 @@ protected function _toHtml()
}

/**
* Return Tab title
*
* @return string
* {@inheritdoc}
*/
public function getTabTitle()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,7 @@ protected function _construct()
}

/**
* Return Tab title
*
* @return string
* {@inheritdoc}
*/
public function getTabTitle()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,19 +108,15 @@ protected function _getGoogleExperiment()
protected abstract function _getEntity();

/**
* Can show tab in tabs
*
* @return boolean
* {@inheritdoc}
*/
public function canShowTab()
{
return $this->_helperData->isGoogleExperimentActive();
}

/**
* Tab is hidden
*
* @return boolean
* {@inheritdoc}
*/
public function isHidden()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,19 +44,15 @@ protected function _getEntity()
}

/**
* Return Tab label
*
* @return string
* {@inheritdoc}
*/
public function getTabLabel()
{
return __('Product View Optimization');
}

/**
* Return Tab title
*
* @return string
* {@inheritdoc}
*/
public function getTabTitle()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,19 +44,15 @@ protected function _getEntity()
}

/**
* Return Tab label
*
* @return string
* {@inheritdoc}
*/
public function getTabLabel()
{
return __('Page View Optimization');
}

/**
* Return Tab title
*
* @return string
* {@inheritdoc}
*/
public function getTabTitle()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,7 @@ protected function _construct()
}

/**
* Return Tab label
*
* @return string
* {@inheritdoc}
*/
public function getTabLabel()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,39 +64,31 @@ public function __construct(
}

/**
* Return Tab label
*
* @return string
* {@inheritdoc}
*/
public function getTabLabel()
{
return __('General Information');
}

/**
* Return Tab title
*
* @return string
* {@inheritdoc}
*/
public function getTabTitle()
{
return __('General Information');
}

/**
* Can show tab in tabs
*
* @return boolean
* {@inheritdoc}
*/
public function canShowTab()
{
return true;
}

/**
* Tab is hidden
*
* @return boolean
* {@inheritdoc}
*/
public function isHidden()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,39 +44,31 @@ protected function _construct()
}

/**
* Return Tab label
*
* @return string
* {@inheritdoc}
*/
public function getTabLabel()
{
return __('Related Orders');
}

/**
* Return Tab title
*
* @return string
* {@inheritdoc}
*/
public function getTabTitle()
{
return __('Related Orders');
}

/**
* Can show tab in tabs
*
* @return boolean
* {@inheritdoc}
*/
public function canShowTab()
{
return true;
}

/**
* Tab is hidden
*
* @return boolean
* {@inheritdoc}
*/
public function isHidden()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,29 +89,23 @@ protected function _construct()
}

/**
* Return Tab label
*
* @return string
* {@inheritdoc}
*/
public function getTabLabel()
{
return __('Billing Agreements');
}

/**
* Return Tab title
*
* @return string
* {@inheritdoc}
*/
public function getTabTitle()
{
return __('Billing Agreements');
}

/**
* Can show tab in tabs
*
* @return boolean
* {@inheritdoc}
*/
public function canShowTab()
{
Expand All @@ -120,9 +114,7 @@ public function canShowTab()
}

/**
* Tab is hidden
*
* @return boolean
* {@inheritdoc}
*/
public function isHidden()
{
Expand Down
Loading

0 comments on commit 87c9601

Please sign in to comment.