Update Home Page content after cache hit (magento#2230)

- Remove redundant loading flag and null response on no data
magento-obsessive-owls · Jun 3, 2020 · 41fe91e · 41fe91e
1 parent 7aa2b97
commit 41fe91e
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/packages/venia-ui/lib/RootComponents/CMS/cms.js b/packages/venia-ui/lib/RootComponents/CMS/cms.js
@@ -13,7 +13,7 @@ import defaultClasses from './cms.css';
 const CMSPage = props => {
     const { id } = props;
     const classes = mergeClasses(defaultClasses, props.classes);
-    const { loading, error, data } = useQuery(cmsPageQuery, {
+    const { error, data } = useQuery(cmsPageQuery, {
         variables: {
             id: Number(id),
             onServer: false
@@ -28,12 +28,8 @@ const CMSPage = props => {
         return <div>Page Fetch Error</div>;
     }
 
-    if (loading && (!data && !data.cmsPage)) {
-        return fullPageLoadingIndicator;
-    }
-
     if (!data) {
-        return null;
+        return fullPageLoadingIndicator;
     }
 
     const { content_heading, title } = data.cmsPage;