Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PWA-1101] Add support for Configurable Product Image Setting #3

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

eug123
Copy link

@eug123 eug123 commented Nov 18, 2020

Description

TODO: Describe your changes in detail here.

Related Issue

Closes #ISSUE_NUMBER.

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Go to the FOO page.
  2. Verify the BAR shows up.
  3. Make sure BAZ does a thing.

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

sathiyaaa and others added 5 commits November 16, 2020 13:03

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
… changed the function name in both the occurences (magento#2807)

Co-authored-by: Stephen <sirugh@users.noreply.github.com>

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Co-authored-by: Stephen <sirugh@users.noreply.github.com>
* Update index.md

* Update pwa-devdocs/src/technologies/overview/index.md

Co-authored-by: Stephen <sirugh@users.noreply.github.com>

Co-authored-by: Stephen <sirugh@users.noreply.github.com>
Co-authored-by: James Calcaben <jcalcaben@users.noreply.github.com>
* Add TOC entry

* Add new topic file and outline

* Add how it works section

* Add interceptor pattern section and image

* Add content for Targets section

* Add content for Intercept files

* Finish Declare file content

* Add content for Targets in PWA Studio packages

* Add list of extension examples

* Add extensibility overview diagram

* Apply suggestions from code review

Co-authored-by: Andy Terranova <13182778+supernova-at@users.noreply.github.com>

* Fix links

* Fix linting issues

* Add example intercept file content

Co-authored-by: Andy Terranova <13182778+supernova-at@users.noreply.github.com>
Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants