Skip to content

MC-30392: De-couple Authorize.net payment methods integrations from core in 2.4.0 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

MC-30392: De-couple Authorize.net payment methods integrations from core in 2.4.0 #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions dev/tests/unit/Magento/FunctionalTestFramework/Test/Util/ActionMergeUtilTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ public function testValidMagentoCLISecretFunction()
$actionObjectOne = new ActionObject(
'actionKey1',
'magentoCLI',
['command' => 'config:set cms/wysiwyg/enabled {{_CREDS.payment_authorizenet_login}}']
['command' => 'config:set cms/wysiwyg/enabled {{_CREDS.payment_method_login}}']
);
$actionObject = [$actionObjectOne];

Expand All @@ -232,7 +232,7 @@ public function testValidMagentoCLISecretFunction()
$expectedValue = new ActionObject(
'actionKey1',
'magentoCLISecret',
['command' => 'config:set cms/wysiwyg/enabled {{_CREDS.payment_authorizenet_login}}']
['command' => 'config:set cms/wysiwyg/enabled {{_CREDS.payment_method_login}}']
);
$this->assertEquals($expectedValue, $result['actionKey1']);
}
Expand All @@ -248,7 +248,7 @@ public function testValidCreateDataSecretFunction()
$actionObjectOne = new ActionObject(
'actionKey1',
'field',
['value' => '{{_CREDS.payment_authorizenet_login}}']
['value' => '{{_CREDS.payment_method_login}}']
);
$actionObject = [$actionObjectOne];

Expand All @@ -259,7 +259,7 @@ public function testValidCreateDataSecretFunction()
$expectedValue = new ActionObject(
'actionKey1',
'field',
['value' => '{{_CREDS.payment_authorizenet_login}}']
['value' => '{{_CREDS.payment_method_login}}']
);
$this->assertEquals($expectedValue, $result['actionKey1']);
}
Expand Down
4 changes: 2 additions & 2 deletions dev/tests/verification/TestModule/Test/SecretCredentialDataTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@
<field key="price">12.34</field>
</createData>
<createData entity="_defaultProduct" stepKey="createProductWithFieldOverridesUsingSecretCredData1">
<field key="qty">{{_CREDS.payment_authorizenet_trans_key}}</field>
<field key="qty">{{_CREDS.payment_method_trans_key}}</field>
<field key="price">{{_CREDS.carriers_dhl_account_eu}}</field>
</createData>

<fillField selector="{{AdminLoginFormSection.username}}" userInput="Hardcoded" stepKey="fillFieldUsingHardCodedData1"/>
<fillField selector="{{AdminLoginFormSection.username}}" userInput="{{_CREDS.carriers_dhl_id_eu}}" stepKey="fillFieldUsingSecretCredData1"/>

<magentoCLI command="config:set cms/wysiwyg/enabled 0" stepKey="magentoCliUsingHardcodedData1"/>
<magentoCLI command="config:set cms/wysiwyg/enabled {{_CREDS.payment_authorizenet_login}}" stepKey="magentoCliUsingSecretCredData1"/>
<magentoCLI command="config:set cms/wysiwyg/enabled {{_CREDS.payment_method_login}}" stepKey="magentoCliUsingSecretCredData1"/>
</test>
</tests>
4 changes: 2 additions & 2 deletions dev/tests/verification/Tests/SecretCredentialDataTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public function secretCredentialDataTest(AcceptanceTester $I)
);

$createProductWithFieldOverridesUsingSecretCredData1Fields['qty'] =
$I->getSecret("payment_authorizenet_trans_key");
$I->getSecret("payment_method_trans_key");

$createProductWithFieldOverridesUsingSecretCredData1Fields['price'] =
$I->getSecret("carriers_dhl_account_eu");
Expand All @@ -68,7 +68,7 @@ public function secretCredentialDataTest(AcceptanceTester $I)
$I->comment($magentoCliUsingHardcodedData1);

$magentoCliUsingSecretCredData1 = $I->magentoCLI("config:set cms/wysiwyg/enabled " .
$I->getSecret("payment_authorizenet_login"));
$I->getSecret("payment_method_login"));
// stepKey: magentoCliUsingSecretCredData1
$I->comment($magentoCliUsingSecretCredData1);
}
Expand Down
11 changes: 1 addition & 10 deletions etc/config/.credentials.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,6 @@
#magento/carriers_dhl_password_eu=
#magento/carriers_dhl_account_eu=


#magento/payment_authorizenet_login=
#magento/payment_authorizenet_trans_key=
#magento/payment_authorizenet_trans_md5=

#magento/authorizenet_fraud_review_login=
#magento/authorizenet_fraud_review_trans_key=
#magento/authorizenet_fraud_review_md5=

#magento/braintree_enabled_fraud_merchant_account_id=
#magento/braintree_enabled_fraud_merchant_id=
#magento/braintree_enabled_fraud_public_key=
Expand Down Expand Up @@ -72,4 +63,4 @@
#magento/payment_paypal_alternative_payment_methods_express_checkout_us_express_checkout_required_express_checkout_required_express_checkout_api_password=
#magento/payment_paypal_alternative_payment_methods_express_checkout_us_express_checkout_required_express_checkout_required_express_checkout_api_signature=

#magento/fraud_protection_signifyd_api_key=
#magento/fraud_protection_signifyd_api_key=