Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect implementation of Thumbnail::prepareDataSource #1711

Closed
sivaschenko opened this issue Aug 4, 2020 · 1 comment · Fixed by magento/magento2#29435
Closed

Incorrect implementation of Thumbnail::prepareDataSource #1711

sivaschenko opened this issue Aug 4, 2020 · 1 comment · Fixed by magento/magento2#29435
Assignees
@jmonteros422
Labels
Backend Priority: P3 May be fixed according to the position in the backlog Progress: done Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround
Milestone
2.1.0

Comments

@sivaschenko
Copy link
Member

sivaschenko commented Aug 4, 2020 •
edited
Loading

  • DataObject should be replaced with a model in \Magento\MediaGalleryCatalogUi\Ui\Component\Listing\Columns\Thumbnail::prepareDataSource
@m2-assistant
Copy link

m2-assistant bot commented Aug 4, 2020

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

@sivaschenko sivaschenko added this to the 2.1.0 milestone Aug 4, 2020
@sivaschenko sivaschenko added Priority: P3 May be fixed according to the position in the backlog and removed Progress: ready for grooming labels Aug 4, 2020
@sivaschenko sivaschenko added Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround and removed Progress: ready for grooming labels Aug 4, 2020
@jmonteros422 jmonteros422 self-assigned this Aug 7, 2020
jmonteros422 added a commit to jmonteros422/magento2-1 that referenced this issue Aug 7, 2020
@jmonteros422
magento/adobe-stock-integration#1711: Use product model instead of da…
11d0a35 
…ta object for catalog image helper init
@jmonteros422 jmonteros422 mentioned this issue Aug 7, 2020
Merged
4 tasks
jmonteros422 added a commit to jmonteros422/magento2-1 that referenced this issue Aug 7, 2020
@jmonteros422
magento/adobe-stock-integration#1711: Use product model instead of da…
25133c5 
…ta object for catalog image helper init - Apply PR suggestion
@sivaschenko sivaschenko changed the title Use product model instead of data object for catalog image helper init Incorrect implementation of Thumbnail::prepareDataSource Aug 7, 2020
jmonteros422 added a commit to jmonteros422/magento2-1 that referenced this issue Aug 7, 2020
@jmonteros422
magento/adobe-stock-integration#1711: Use product model instead of da…
c72447f 
…ta object for catalog image helper init - Revised approach based from pr suggestion
jmonteros422 added a commit to jmonteros422/magento2-1 that referenced this issue Aug 11, 2020
@jmonteros422
magento/adobe-stock-integration#1711: Use product model instead of da…
36427dc 
…ta object for catalog image helper init - Update MFTF for image placeholder verification, update branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmonteros422 jmonteros422

Labels
Backend Priority: P3 May be fixed according to the position in the backlog Progress: done Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround
Projects
None yet
Milestone
2.1.0
2 participants
@sivaschenko @jmonteros422