Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdminAdobeStockSafeContentFilterTest fails consistently #684

Closed
filmaj opened this issue Nov 11, 2019 · 0 comments
Closed

AdminAdobeStockSafeContentFilterTest fails consistently #684

filmaj opened this issue Nov 11, 2019 · 0 comments
Labels
MFTF tests MFTF tests coverage
Milestone

Comments

@filmaj
Copy link
Contributor

filmaj commented Nov 11, 2019

Steps to reproduce (*)

Run the AdminAdobeStockSafeContentFilterTest:

vendor/bin/mftf run:test AdminAdobeStockSafeContentFilterTest --remove

Expected result (*)

Passes without failure.

Actual result (*)

Log when running in headless Chrome on Mac OS:

4) AdminAdobeStockSafeContentFilterTestCest: Admin adobe stock safe content filter test
 Test  tests/functional/Magento/FunctionalTest/_generated/adobe_stock_integration_suite/AdminAdobeStockSafeContentFilterTestCest.php:AdminAdobeStockSafeContentFilterTest
 Step  Click ".adobe-sign-in-button"
 Fail  Failed asserting that '347 records found' does not contain "347 records found".

Scenario Steps:

 50. // Exiting Action Group [logout] logout
 49. $I->amOnPage("/admin_hgkq1l/admin/auth/logout/") at tests/functional/Magento/FunctionalTest/_generated/adobe_stock_integration_suite/AdminAdobeStockSafeContentFilterTestCest.php:75
 48. // Entering Action Group [logout] logout
 47. // Exiting Action Group [resetAdminDataGridToDefaultView] resetAdminDataGridToDefaultView
 46. $I->waitForPageLoad(30) at tests/functional/Magento/FunctionalTest/_generated/adobe_stock_integration_suite/AdminAdobeStockSafeContentFilterTestCest.php:72
 45. $I->see("Default View","div.admin__data-grid-action-bookmarks button[d...") at tests/functional/Magento/FunctionalTest/_generated/adobe_stock_integration_suite/AdminAdobeStockSafeContentFilterTestCest.php:71

More Context

I think this is happening since we applied a 'default' gallery / query for Adobe Stock to show in the integration. The test implementation is sub-par, I think, because the test loads up the Adobe Stock search grid, applies the 'safe content only' filter, then expects the number of results to differ from the 'default' view. But this is a bad assumption as the default view does not contain any offensive content. Anyways, we probably don't want to incorporate loading/viewing offensive content as part of the tests. So a different approach should be taken. Any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MFTF tests MFTF tests coverage
Projects
None yet
Development

No branches or pull requests

3 participants