Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdminAdobeStockSafeContentFilterTest fails consistently #693

Merged
merged 3 commits into from
Nov 12, 2019
Merged

AdminAdobeStockSafeContentFilterTest fails consistently #693

merged 3 commits into from
Nov 12, 2019

Conversation

engcom-Golf
Copy link
Contributor

@engcom-Golf engcom-Golf commented Nov 12, 2019

Description (*)

Added words filter to disable default gallery_id filter

Fixed Issues (if relevant)

  1. AdminAdobeStockSafeContentFilterTest fails consistently #684: AdminAdobeStockSafeContentFilterTest fails consistently

Manual testing scenarios (*)

Run functional tests

@engcom-Golf engcom-Golf requested a review from filmaj November 12, 2019 09:28
Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this!

I can confirm this fixes the test in my local environment.

I have left two minor requests for changes, after these are applied, we can merge this PR, I think.

Nazar65 and others added 2 commits November 12, 2019 15:55
…ntFilterTest.xml

Co-Authored-By: Fil Maj <maj.fil@gmail.com>
…ntFilterTest.xml

Co-Authored-By: Fil Maj <maj.fil@gmail.com>
@filmaj filmaj merged commit 561f73b into magento:develop Nov 12, 2019
@ghost
Copy link

ghost commented Nov 12, 2019

Hi @engcom-Golf, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants