Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved issue 691 #709

Closed
wants to merge 1 commit into from
Closed

Resolved issue 691 #709

wants to merge 1 commit into from

Conversation

drpayyne
Copy link
Contributor

Description

  • Added left//right arrow navigation for image preview in grid
  • Various checks involved to prevent JS errors
    • Check if image preview is opened
    • Check if Adobe Stock panel is opened
    • Prevent left navigation for first image
    • Prevent right navigation for last image

Fixed Issues

Manual testing scenarios

  1. Open Adobe Stock panel
  2. Open any image preview
  3. Navigate left and right with keyboard arrow keys

@sivaschenko
Copy link
Member

Hi @drpayyne thanks for the pull request! This issue should be fixed in Magento/Ui/view/base/web/js/grid/columns/image-preview.js - please open a pull request to magento2 repository.

Also, pease consider using Magento_Ui/js/lib/key-codes library

@ghost
Copy link

ghost commented Nov 14, 2019

Hi @drpayyne, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sivaschenko sivaschenko deleted the issue-691 branch February 14, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants