Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Adobe Stock button is not active on Edit Product Page in Admin #748

Merged
merged 11 commits into from
Nov 28, 2019
Merged

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Nov 21, 2019

Description (*)

Fixed Issues (if relevant)

  1. Search Adobe Stock button is not active on Edit Product Page in Admin #689: Search Adobe Stock button is not active on Edit Product Page in Admin
    Depend on Added 'clearEvent' to eventBus to prevent multiple attach event on wysiwyg editor magento2#25671

Manual testing scenarios (*)

  1. Open Adobe Stock on product page in content tab
  2. Open media Gallery from both instance

@engcom-Delta
Copy link

Hi @Nazar65 During testing PR changes was found issue with Locate functionality that cannot navigate to saved image in second opened wysiwyg editor.

Manual testing scenario:

  • Configure the integration in Stores -> Configuration -> System -> Adobe Stock Integration fieldset
  • Login to admin panel
  • Navigate to Catalog->Products
  • Click Add Product button
  • Expand "Content" section button
  • Click "Insert/edit image" in wysiwyg Editor for Description field
  • Click "Search Adobe Stock" button to open images grid
  • Open image preview for first image and click Save Preview
  • Close Media Gallery
  • Click "Insert/edit image" in wysiwyg Editor for Short Description field
  • Click "Search Adobe Stock" button to open images grid
  • Click on an first image to expand the preview
  • Click Locate button

Expected Result:
Media Gallery is opened and saved image is selected

Actual result:
Cannot navigate to saved image using Locate button. Wysiwyg image popup is shown instead of Media Gallery

image

@Nazar65
Copy link
Member Author

Nazar65 commented Nov 26, 2019

Hi @engcom-Delta thank you for attention on this PR, the issue related to that Adobe Gallery never worked with two WYSIWYG instances or greater, so we need to always get active adobe-stock-grid in the page, Te issue is fixed now, thank you very much.

@engcom-Delta
Copy link

✔️ QA passed

@sivaschenko sivaschenko merged commit d74e996 into magento:develop Nov 28, 2019
@ghost
Copy link

ghost commented Nov 28, 2019

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants