-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MQE-1932: MFTF tests deprecation process #348
MQE-1932: MFTF tests deprecation process #348
Conversation
Just repeating what I've said from previous reviews, but I'd prefer only using syntax 1 for absolute consistency in deprecation. This process will already be cumbersome, so keeping everything lean where possible is a must in my opinion. |
Personally I prefer syntax 1 for its consistency. @KevinBKozan Do you mean syntax 1 or syntax 2? |
@jilu1 apologies, I did mean Syntax 1 👍 |
|---|---|---| | ||
|ActionGroup|`<actionGroup>`|**Yes** | ||
| |`<actionGroup>` `<action>`|No | ||
| |`<actionGroup>` `<argument>`|**Yes** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it look like if an argument
if deprecated?
For example, if an action group has an argument
and 5 different actions
in that action group reference that argument
, then how can you deprecated the argument
without also affecting those 5 actions
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomreece Good catch! Not all action group argument deprecation can be completely isolated. To make it simple, let's remove it from the list. Fixed.
I prefer syntax 1 because it is consistent. |
@paliarush @okolesnyk It looks like the formal Architectural Discussions meeting process has changed. Can you please review this document and I can setup a informal meeting if further discussion is needed? Thanks! |
I updated with more generic version number and make sure major release ends with 0. |
Solution
Propose MFTF test deprecation syntax and process
Requested Reviewers
@paliarush @okolesnyk