magento/architecture#: GraphQl. Add a mutation for subscribe feature #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
СС: @nrkapoor as a PO of GraphQL scope |
atwixfirster
force-pushed
the
subscribeEmailToNewsletter
branch
from
da80fb4 to
a00c6ec
Compare
paliarush
requested changes
Apr 6, 2020
| } | ||
|
|
||
| type SubscribeOutput { | ||
| status: Int! @doc(description: "Returns a status of subscription") |
There was a problem hiding this comment.
Please introduce enum instead of int here.
| @@ -0,0 +1,7 @@ | |||
| type Mutation { | |||
| subscribeEmailToNewsletter(email: String!): SubscribeOutput @doc(description:"Adds an email into a newsletter subscription") | |||
There was a problem hiding this comment.
To be consistent with other mutations, please change output to SubscribeEmailToNewsletterOutput (mutation name + suffix)
There was a problem hiding this comment.
done
Thank you!
There was a problem hiding this comment.
@paliarush , did you have a chance to review the applied changes?
Thank you!
atwixfirster
force-pushed
the
subscribeEmailToNewsletter
branch
from
a00c6ec to
e388de7
Compare
atwixfirster
force-pushed
the
subscribeEmailToNewsletter
branch
from
e388de7 to
22c3327
Compare
paliarush
approved these changes
May 8, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is a subscribe field on a standard Magento storefront:
Currently, GraphQl does not have a mutation which allow to subscribe guest/customer into a newsletter subscription.
Solution
SubscribeOutput.statusmay return the next statuses:Depends on status the possible messages will be displayed, for example on PWA side:
SubscribeOutput.status= Not Active)PR: magento/magento2#27586
Issue in CORE repo: magento/magento2#27337
Requested Reviewers
Thank you!