-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update proposal for custom attributes schema #456
base: master
Are you sure you want to change the base?
Update proposal for custom attributes schema #456
Conversation
… with multiple values
… with multiple values
@melnikovi Does this align with the custom attribute proposal from @akaplya for Product? #429 |
@@ -8,13 +8,42 @@ One workaround for "getting all fields" is based on schema introspection, it all | |||
|
|||
# Proposed solution | |||
|
|||
To account for dynamic nature of EAV attributes and the need of "getting all fields" in product search queries, `custom_attributes: [CustomAttribute]!` container will be introduced. | |||
To account for dynamic nature of EAV attributes and the need of "getting all fields" in product search queries,we can introduce `custom_attributes: [CustomAttribute]!` container. | |||
|
|||
```graphql | |||
type CustomAttribute { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have to add "type" opinion here to be able to render the appropriate template (datetime, text, multi-select, checkbox ...)
E.g.
"attributes":[
{
"code":"multiselect_attribute",
"type":"multiselect",
"values":[
"Option 1",
"Option 2"
]
}
]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attributes are going to be displayed as information and not as fields you can control, so I don't think it's necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will be useful to render field properly on UI without complex logic. E.g. for "Date" field - "10-11-2020"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, they are needed for the forms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have this data already available in the scope of customAttributeMetadata
query. Since update frequency for attribute metadata and product attribute values is different, it makes sense to separate them to avoid excessive payload size.
… with multiple values
code: String! | ||
} | ||
|
||
type SingleValueCustomAttribute extends CustomAttributeInterface { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even if this adds more complexity, it's the graphql way to do it and I prefer it
@@ -8,13 +8,42 @@ One workaround for "getting all fields" is based on schema introspection, it all | |||
|
|||
# Proposed solution | |||
|
|||
To account for dynamic nature of EAV attributes and the need of "getting all fields" in product search queries, `custom_attributes: [CustomAttribute]!` container will be introduced. | |||
To account for dynamic nature of EAV attributes and the need of "getting all fields" in product search queries, we can introduce `custom_attributes: [CustomAttribute]!` container (recommended approach). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do fragments bring any value for PWA since we still prefer these flat single structure arrays vs infterfaces?
@@ -0,0 +1,222 @@ | |||
type Query { | |||
customAttributeMetadataV2(attributes: [AttributeMetadataInput!]!): CustomAttributeMetadata | |||
customAttributesLists(listType: CustomAttributesListsEnum): CustomAttributeMetadata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
customAttributesLists - do we need a better name for this
|
Problem
Current schema for custom attributes doesn't support attributes that can have multiple values (checkbox, multiselect).
Solution
Requested Reviewers