Customer Newsletter subscription label changes. #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthampy
reviewed
Dec 16, 2020
| @@ -3,7 +3,7 @@ type Mutation { | |||
| } | |||
|
|
|||
| type SubscribeEmailToNewsletterOutput { | |||
| status: SubscriptionStatusesEnum @doc(description: "Returns a status of subscription") | |||
| status: SubscriptionStatusesEnum @doc(description: "Returns a status of newsletter subscription") | |||
| } | |||
|
|
|||
| enum SubscriptionStatusesEnum { | |||
There was a problem hiding this comment.
To better align with the existing enum values, change "NOT_ACTIVE" status to INACTIVE
There was a problem hiding this comment.
yes but we can't remove that value
we have to keep it, add a comment that's not used and add "INACTIVE" as a new value
|
@dthampy I have made changes based on your comment. |
cpartica
requested changes
Jan 14, 2021
| @@ -3,7 +3,7 @@ type Mutation { | |||
| } | |||
|
|
|||
| type SubscribeEmailToNewsletterOutput { | |||
| status: SubscriptionStatusesEnum @doc(description: "Returns a status of subscription") | |||
| status: SubscriptionStatusesEnum @doc(description: "Returns a status of newsletter subscription") | |||
| } | |||
|
|
|||
| enum SubscriptionStatusesEnum { | |||
There was a problem hiding this comment.
yes but we can't remove that value
we have to keep it, add a comment that's not used and add "INACTIVE" as a new value
|
@cpartica I have updated the value of ENUM type with deprecated note. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Customer Newsletter Subscription label changes.
Solution
Just add the Newsletter keyword before subscription. The label will be clear for the subscription to the newsletter.
Requested Reviewers