-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated purchase order graphql schema #510
base: master
Are you sure you want to change the base?
Updated purchase order graphql schema #510
Conversation
- Split into separate purchase-order and purchase-order-rule schemas per module - Added created_at and updated_at fileds to PurchaseOrder - Added addPurchaseOrderItemsToCart mutation:q
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- we need to extract approval_flow from Purchase order object and add it to
purchase-order-rule.graphqls
(line 115) - do we need a
StoreConfig
Setting as well? How does the PWA know how to render "Place purchase Order" button in cart? I even wonder if we should keep PO enabled in the customer - because even if it's customer specific - PWA will still read settings from StoreConfig - and the value in the Storeconfig can be customer specific - but we don't have to give PWA a custom place to look for settings - it just adds additional complexity to the frontend logic - when placing the purchase order, we might need a purchase order id or a full object as a result of the placeOrder mutation or a mutation similar to
placeNegotiableQuoteOrder
that has aPlaceNegotiableQuoteOrderOutput
- note thatOrder
ids are different thanpurchaseOrder
Ids - we also need to think about available payment methods for purchase orders - I don't think we can grab those (both online and offline) - note that we do have to know which ones are online or offline - because there's a message to be displayed for online ones in the cart that payment will be collected later when PO is approved
- can we show/hide the tabs on the approval page using the proposed schema? how?
- we should find a way for PurchaseOrder to be concrete impl. of an OrderInterface just like Negotiable Quote is a concrete impl. of a Quote (a cart object) - that way by placing an order - a client can request concrete info of a Purchase Order by knowing that the result is a purchase order with results from the server and just using inline fragments -
Thanks for review @cpartica ! Updates and comments:
Questions:
|
|
|
|
Updated purchase order graphql schema