Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product images not found for SF API #375

Closed
wants to merge 2 commits into from

Conversation

aleksejsbaranovs10
Copy link

@aleksejsbaranovs10 aleksejsbaranovs10 commented Oct 9, 2020

Description (*)

Related Pull Requests

https://github.com/magento/saas-export/pull/142
https://github.com/magento/partners-magento2-infrastructure/pull/42

Fixed Issues (if relevant)

  1. Fixes Product images not found for SF API #367

Questions or comments

Code Review Checklist (*)

See dataied checklist

  • Story AC is completed
  • proposed changes correspond to Magento Technical Vision
  • new or changed code is covered with web-api/integration tests (if applicable)
    • expected results in test verified with data from fixture
  • no backward incompatibile changes
  • Export API (et_schema.xml) and SF API schemas (proto schema) are reflected in the codebase
    • prerequisite: story branch created with all needed generated classes according to proposes schema-changes
    • DTO classes do not contain any manual changes (Magento\CatalogExportApi*, Magento\CatalogStorefrontApi*)
  • Class usage: magento/catalog-storefront repo don't use directly classes from magento/saas-export repo and vise-verse
    • Check composer.json dependencies
  • Legacy code is deleted
    • Any Data Providers present in Connector part (Magento\CatalogStorefrontConnector, Magento*Extractor modules)
    • And Data Providers from Export API (magento/saas-export repo) that is not relevant anymore
    • Any DTO for Export API/SF API which does not reflect current schema: et_schema, proto schema
    • Any “mapper” on Message Broker (between Export API and SF API)
      • if mapper still needed, verify fields used in mapping, remove not relevant fields

@aleksejsbaranovs10
Copy link
Author

@magento run all tests

@aleksejsbaranovs10
Copy link
Author

@magento run all tests

@vgoncharenko
Copy link
Contributor

Thank you for your contributio.
Your PR was merged to internal private fork: https://github.com/magento-commerce/catalog-storefront-ce/pull/4

@nrkapoor nrkapoor added this to the EAP milestone Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product images not found for SF API
5 participants