Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[357.6] GetVariantsMatch service #414

Closed
bricht opened this issue Nov 9, 2020 · 2 comments
Closed

[357.6] GetVariantsMatch service #414

bricht opened this issue Nov 9, 2020 · 2 comments
Assignees
Milestone

Comments

@bricht
Copy link
Contributor

bricht commented Nov 9, 2020

Subtask of #357

Depends on #331

Steps
Implement GetVariantsMatch service.

message OptionSelectionRequest
{
string store = 1;
// array of option_values with the following format parent_id:option_id/optionValue.uid
// @see ProductValue.option_values
repeated string values = 2;
}

service VariantService {
  rpc GetVariantsMatch (OptionSelectionRequest) returns (ProductVariantResponse) {}
}

see https://github.com/magento/catalog-storefront/blob/develop/dev/docs/designDocuments/Configurable-products-option-variants.md for technical details.
cover with API-functional tests

@m2-assistant
Copy link

m2-assistant bot commented Nov 9, 2020

Hi @bricht. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


@nrkapoor nrkapoor added this to the EAP milestone Nov 9, 2020
@RuslanKostiv1
Copy link
Contributor

@bricht , we already have an issue for GetVariantsMatch
#359 , this one can be closed as duplicate

@bricht bricht closed this as completed Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants