Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetVariantsMatch service #359

Closed
magento-engcom-team opened this issue Sep 29, 2020 · 3 comments · Fixed by #442
Closed

GetVariantsMatch service #359

magento-engcom-team opened this issue Sep 29, 2020 · 3 comments · Fixed by #442

Comments

@magento-engcom-team
Copy link

magento-engcom-team commented Sep 29, 2020

Depends on #357

Steps

  • implement GetVariantsMatch request for VariantSearchService in proto:
message OptionSelectionRequest
{
  string store = 1;
  repeated string values = 2;
}

message ProductVariantResponse {
  repeated ProductVariant matched_variants = 3;
}

service VariantService {
  rpc GetVariantsMatch (OptionSelectionRequest) returns (ProductVariantResponse);
}
@magento-engcom-team
Copy link
Author

The issue was exported from the internal JIRA. The link to the original JIRA issue: https://jira.corp.magento.com/browse/SFAPP-84

@m2-assistant
Copy link

m2-assistant bot commented Sep 29, 2020

Hi @magento-engcom-team. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


@bricht
Copy link
Contributor

bricht commented Nov 17, 2020

@magento I am working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants