Variants GetVariantsMatch Service #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Added GetVariantsMatch functionality -Added api test
|
@magento run all tests |
-Syntax fixes
|
@magento run all tests |
| $simples[] = $this->productRepository->get($sku); | ||
| } | ||
| $availableVariants = $this->getExpectedProductVariants($configurable, $simples); | ||
| self::assertCount(9, $availableVariants, 'Wrong number of expected variants'); |
There was a problem hiding this comment.
We don't test here our API, this part already been tested by Magento. If this error occurs "Wrong number of expected variants" we would guess we have an issue with API, but the problem will be with Magento repositories.
There was a problem hiding this comment.
Removed this part. We will get null pointer anyway if its empty, but I guess that's an error and not test failure.
-Removed validation of irrelevant part of test
|
@magento run all tests |
|
@magento run Static Tests |
added 3 commits
December 1, 2020 11:49
-Return empty response instead of error, if product variants do not match selection
-Test fix
|
@magento run Static Tests |
-Added getVariantsExactlyMatch service -Added getVariantsInclude service -Added test cases for these services
|
@magento run all tests |
-Static tests fix
…talog-storefront into 359_get-variants-match-service
|
@magento run all tests |
-Test fix
|
@magento run all tests |
|
@magento import pr to magento-commerce/catalog-storefront-ce |
|
@RuslanKostiv1 the pull request successfully imported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Added GetVariantsMatch functionality
-Added api test
Description (*)
Related Pull Requests
Fixed Issues (if relevant)
Questions or comments
Code Review Checklist (*)
See detailed checklist