Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17] Read API :: Web-Api tests :: Magento\GraphQl\Store\StoreSaveTest::testProductVisibleInNewStore #70

Closed
mslabko opened this issue Jun 12, 2020 · 5 comments

Comments

@mslabko
Copy link
Member

mslabko commented Jun 12, 2020

In the scope of delivery #17 need to fix web-api tests Magento\GraphQl\Store\StoreSaveTest::testProductVisibleInNewStore

Needed branches:

Failed
Magento.GraphQl.Store.StoreSaveTest.testProductVisibleInNewStore (from Magento_GraphQl_Store_StoreSaveTest)

Failing for the past 2 builds (Since Failed#3359 )
Took 15 sec.
Stacktrace
Magento\GraphQl\Store\StoreSaveTest::testProductVisibleInNewStore
Category with name "Category 1" not found in store "new_store"
Failed asserting that actual size 0 matches expected size 1.

/var/www/html/dev/tests/api-functional/testsuite/Magento/GraphQl/Store/StoreSaveTest.php:106
/var/www/html/dev/tests/api-functional/testsuite/Magento/GraphQl/Store/StoreSaveTest.php:29

Dev notes:

  • some classes in catalog-storefront repo are autogenerated (marked as "Generated by the Magento PHP proto generator. DO NOT EDIT!") If you still need to edit them to fix test, please mention it in the comment
@m2-assistant
Copy link

m2-assistant bot commented Jun 12, 2020

Hi @mslabko. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


@ledian-hymetllari
Copy link
Member

I tried to run this test and I am missing a fixture @mslabko @melnikovi

root@app:/var/www/magento2ce/dev/tests/api-functional# ../../../vendor/bin/phpunit -c phpunit_rest.xml testsuite/Magento/GraphQl/Store/StoreSaveTest.php
PHPUnit 9.1.5 by Sebastian Bergmann and contributors.

Error in fixture: "/var/www/magento2ce/dev/tests/integration/testsuite/Magento/Indexer/_files/reindex.php".
Warning: require(/var/www/magento2ce/dev/tests/integration/testsuite/Magento/Indexer/_files/reindex.php): failed to open stream: No such file or directory in /var/www/magento2ce/dev/tests/integration/framework/Magento/TestFramework/Annotation/AbstractDataFixture.php:89.
#0 /var/www/magento2ce/dev/tests/integration/framework/Magento/TestFramework/Annotation/AbstractDataFixture.php(89): {closure}(2, 'require(/var/ww...', '/var/www/magent...', 89, Array)
#1 /var/www/magento2ce/dev/tests/integration/framework/Magento/TestFramework/Annotation/AbstractDataFixture.php(89): require()
#2 /var/www/magento2ce/dev/tests/integration/framework/Magento/TestFramework/Annotation/AbstractDataFixture.php(115): Magento\TestFramework\Annotation\AbstractDataFixture->_applyOneFixture('/var/www/magent...')
#3 /var/www/magento2ce/dev/tests/api-functional/framework/Magento/TestFramework/Annotation/ApiDataFixture.php(35): Magento\TestFramework\Annotation\AbstractDataFixture->_applyFixtures(Array)
#4 [internal function]: Magento\TestFramework\Annotation\ApiDataFixture->startTest(Object(Magento\GraphQl\Store\StoreSaveTest))
#5 /var/www/magento2ce/dev/tests/integration/framework/Magento/TestFramework/EventManager.php(49): call_user_func_array(Array, Array)
#6 /var/www/magento2ce/dev/tests/integration/framework/Magento/TestFramework/Event/PhpUnit.php(127): Magento\TestFramework\EventManager->fireEvent('startTest', Array)
#7 /var/www/magento2ce/vendor/phpunit/phpunit/src/Framework/TestResult.php(407): Magento\TestFramework\Event\PhpUnit->startTest(Object(Magento\GraphQl\Store\StoreSaveTest))
#8 /var/www/magento2ce/vendor/phpunit/phpunit/src/Framework/TestResult.php(624): PHPUnit\Framework\TestResult->startTest(Object(Magento\GraphQl\Store\StoreSaveTest))
#9 /var/www/magento2ce/vendor/phpunit/phpunit/src/Framework/TestCase.php(772): PHPUnit\Framework\TestResult->run(Object(Magento\GraphQl\Store\StoreSaveTest))
#10 /var/www/magento2ce/vendor/phpunit/phpunit/src/Framework/TestSuite.php(639): PHPUnit\Framework\TestCase->run(Object(PHPUnit\Framework\TestResult))
#11 /var/www/magento2ce/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(653): PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
#12 /var/www/magento2ce/vendor/phpunit/phpunit/src/TextUI/Command.php(108): PHPUnit\TextUI\TestRunner->run(Object(PHPUnit\Framework\TestSuite), Array, Array, true)
#13 /var/www/magento2ce/vendor/phpunit/phpunit/src/TextUI/Command.php(68): PHPUnit\TextUI\Command->run(Array, true)
#14 /var/www/magento2ce/vendor/phpunit/phpunit/phpunit(61): PHPUnit\TextUI\Command::main()
#15 {main}

=== Memory Usage System Stats ===
Memory usage (OS): 125.57M (313.93% of 40.00M reported by PHP)
Estimated memory leak: 85.57M (68.15% of used memory)

root@app:/var/www/magento2ce/dev/tests/api-functional#

@ledian-hymetllari
Copy link
Member

@mslabko I was able to pass test for this one. For branch 2.4 there is missing this file

dev/tests/integration/testsuite/Magento/Indexer/_files/reindex.php

I got this file from this branch develop-storefront, added it and I was able to pass the tests. Should I add this missing file for branch 2.4?

image

@ledian-hymetllari
Copy link
Member

image

@ledian-hymetllari
Copy link
Member

After discussed with @mslabko , we can close this issue, it is passing now tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants