Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read API :: APIs to read data from catalog storefront data storage #17

Closed
nrkapoor opened this issue May 26, 2020 · 5 comments · Fixed by #45
Closed

Read API :: APIs to read data from catalog storefront data storage #17

nrkapoor opened this issue May 26, 2020 · 5 comments · Fixed by #45
Assignees
@mslabko @kokoc @vzabaznov
Labels
Read API Story #17
Milestone
Sprint 1

Comments

@nrkapoor
Copy link

nrkapoor commented May 26, 2020 •
edited
Loading

As a Magento Developer, 

I would like to create catalog storefront APIs to read product system and custom attributes data in storefront elasticsearch index

So that

GraphQL can call this API to read the product data via an optimized API. 

Acceptance Criteria

  • APIs are REST & gRPC compatible.
  • APIs can scale up to 1200 concurrent reads with a p90 of <250ms. 
  • APIs must pass all existing Magento GraphQL integration tests.

cc: [~imelnikov] [~iminiailo]
@maghamed maghamed added this to the Sprint 1 milestone Jun 3, 2020
@maghamed maghamed assigned kokoc and unassigned paliarush Jun 4, 2020
@vgoncharenko vgoncharenko mentioned this issue Jun 5, 2020
Open
This was referenced Jun 5, 2020
Closed
Merged
This was referenced Jun 9, 2020
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
@mslabko
Copy link
Member

mslabko commented Jun 10, 2020 •
edited
Loading

Workin on Magento.GraphQl.Catalog.CategoriesQuery.CategoriesFilterTest.testMinimumMatchQueryLength
Magento.GraphQl.Catalog.CategoriesQuery.CategoriesFilterTest.testMinimumMatchQueryLength
Magento.GraphQl.Catalog.CategoryListTest.testMinimumMatchQueryLength
Magento.GraphQl.Catalog.CategoryListTest.testMinimumMatchQueryLength

Magento\GraphQl\Quote\Guest\AddSimpleProductToCartTest::testAddProductToCartWithImage

This was referenced Jun 11, 2020
Closed
Closed
Open
Closed
Closed
@vzabaznov
Copy link
Contributor

Full list

Magento.GraphQl.Catalog.CategorySpecificFieldsTest.testSpecificCategoryFields with data set #0
Magento.GraphQl.Catalog.CategorySpecificFieldsTest.testSpecificCategoryFields with data set #0
Magento.GraphQl.Catalog.MediaGalleryTest.testProductSmallImageUrlPlaceholder
Magento.GraphQl.Catalog.MediaGalleryTest.testProductSmallImageUrlPlaceholder
Magento.GraphQl.Catalog.ProductSearchTest.testFilterProductsByDropDownCustomAttribute
Magento.GraphQl.Catalog.ProductSearchTest.testFilterByMultipleProductUrlKeys
Magento.GraphQl.Catalog.ProductSearchTest.testFilterProductsByDropDownCustomAttribute
Magento.GraphQl.Catalog.ProductSearchTest.testFilterByMultipleProductUrlKeys
Magento.GraphQl.Catalog.ProductViewTest.testProductPrices
Magento.GraphQl.Catalog.ProductViewTest.testProductPrices
Magento.GraphQl.CatalogInventory.ProductOnlyXLeftInStockTest.testQueryProductOnlyXLeftInStockEnabled
Magento.GraphQl.CatalogInventory.ProductOnlyXLeftInStockTest.testQueryProductOnlyXLeftInStockEnabled
Magento.GraphQl.GroupedProduct.GroupedProductViewTest.testAllFieldsGroupedProduct
Magento.GraphQl.GroupedProduct.GroupedProductViewTest.testAllFieldsGroupedProduct
Magento.GraphQl.GroupedProduct.ProductViewTest.testGroupedProductAssignedToOneWebsite
Magento.GraphQl.GroupedProduct.ProductViewTest.testGroupedProductItemsAssignedToDifferentWebsites
Magento.GraphQl.GroupedProduct.ProductViewTest.testGroupedProductAssignedToOneWebsite
Magento.GraphQl.GroupedProduct.ProductViewTest.testGroupedProductItemsAssignedToDifferentWebsites
Magento.GraphQl.Quote.Guest.AddSimpleProductToCartTest.testAddProductToCartWithImage
Magento.GraphQl.Quote.Guest.AddSimpleProductToCartTest.testAddProductToCartWithImage
Magento.GraphQl.Store.StoreSaveTest.testProductVisibleInNewStore
Magento.GraphQl.Store.StoreSaveTest.testProductVisibleInNewStore
Magento.GraphQl.CatalogStaging.CategoryStagingTest.testCategoryStaging with data set #0
Magento.GraphQl.ElasticsearchCatalogPermissionsGraphQl.GetProductsWithCatalogPermissionsTest.testSearchProductsAsLoggedInUserWithAllowedPermissions
Magento.GraphQl.Staging.PreviewCatalogRuleTest.testPreviewConfigurableProductWithStagedCategoryAndCatalogRule
Magento.GraphQl.Staging.PreviewCatalogRuleTest.testPreviewSimpleProductWithStagedCategoryAndCatalogRule
Magento.GraphQl.Staging.PreviewCategoryTest.testPreviewCategoryList
Magento.GraphQl.Staging.PreviewCategoryTest.testPreviewCategory
Magento.GraphQl.Staging.PreviewConfigurableProductTest.testPreviewConfigurableProduct

@vzabaznov
Copy link
Contributor

Im working on
Magento.GraphQl.Catalog.MediaGalleryTest.testProductSmallImageUrlPlaceholder
Magento.GraphQl.Catalog.MediaGalleryTest.testProductSmallImageUrlPlaceholder

@vzabaznov vzabaznov self-assigned this Jun 11, 2020
@mslabko
Copy link
Member

mslabko commented Jun 11, 2020

http://10.234.203.225:8080/job/WebAPI-Tests/3360/#showFailuresLink

Fixed:
Magento.GraphQl.Catalog.CategoriesQuery.CategoriesFilterTest.testMinimumMatchQueryLength
Magento.GraphQl.Catalog.CategoriesQuery.CategoriesFilterTest.testMinimumMatchQueryLength
Magento.GraphQl.Catalog.CategoryListTest.testMinimumMatchQueryLength
Magento.GraphQl.Catalog.CategoryListTest.testMinimumMatchQueryLength
Magento\GraphQl\Quote\Guest\AddSimpleProductToCartTest::testAddProductToCartWithImage

This was referenced Jun 12, 2020
Closed
Closed
Closed
@nrkapoor nrkapoor changed the title Storefront API :: APIs to read data from catalog storefront data storage Read API :: APIs to read data from catalog storefront data storage Jun 13, 2020
@mslabko
Copy link
Member

mslabko commented Jun 15, 2020

Working on Magento\GraphQl\CustomerBalance\ApplyStoreCreditToCartTest::testApplyStoreSpecificStoreCredit

@mslabko mslabko mentioned this issue Jun 23, 2020
Closed
This was referenced Jun 23, 2020
Open
Merged
Closed
@RuslanKostiv1 RuslanKostiv1 mentioned this issue Jun 25, 2020
Closed
mmansoor-magento pushed a commit that referenced this issue Nov 13, 2020
@RuslanKostiv1
Merge pull request #17 from magento-commerce/imported-magento-catalog…
30e0b62 
…-storefront-413

[Imported] Product variants
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mslabko mslabko

@kokoc kokoc

@vzabaznov vzabaznov

Labels
Read API Story #17
Projects
None yet
Milestone
Sprint 1
Development

Successfully merging a pull request may close this issue.

Storefront API :: APIs to read data from catalog storefront data storage magento/catalog-storefront
7 participants
@mslabko @kokoc @maghamed @nrkapoor @vzabaznov @paliarush @ddzhura