Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17] Read API :: Integration tests :: Wishlist.Model #54

Closed
mslabko opened this issue Jun 9, 2020 · 4 comments
Closed

[17] Read API :: Integration tests :: Wishlist.Model #54

mslabko opened this issue Jun 9, 2020 · 4 comments

Comments

@mslabko
Copy link
Member

mslabko commented Jun 9, 2020

In the scope of delivery #17 need to fix integration tests Magento.Wishlist.Model*:

Needed branches:

Dev notes:

  • some classes in catalog-storefront repo are autogenerated (marked as "Generated by the Magento PHP proto generator. DO NOT EDIT!") If you still need to edit them to fix test, please mention it in the comment

Example of error:
Stacktrace
Magento\Wishlist\Model\ResourceModel\Item\CollectionTest::testLoadedProductAttributes
Magento\Framework\Exception\LocalizedException: Cannot specify product.

/var/www/html/app/code/Magento/Wishlist/Model/Item.php:376
/var/www/html/dev/tests/integration/tmp/sandbox--23a8fccb4879ec0a108e98befda0d725946cbdfcadd17dfdeeae6767d7a8a6ec/generated/code/Magento/Wishlist/Model/Item/Interceptor.php:95
/var/www/html/dev/tests/integration/testsuite/Magento/Wishlist/Model/ResourceModel/Item/CollectionTest.php:60

@m2-assistant
Copy link

m2-assistant bot commented Jun 9, 2020

Hi @mslabko. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


@ledian-hymetllari
Copy link
Member

ledian-hymetllari commented Jun 10, 2020

@michael I checked this issue, did a couple of tests and debugging, and after discussed with Serhii Kovalenko, this PR fixed did the trick to fix the issues:

magento/magento2#28669

@mslabko
Copy link
Member Author

mslabko commented Jun 11, 2020

This test was fixed in the scope of #55 (comment)

Please, fill free to review related PR. In case you found another root cause of the test failure, please mention it and reopen this ticket.

@skovalenk
Copy link
Contributor

Tickets:
#65
#55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants